Commit Graph
5269 Commits
Author SHA1 Message Date
jetstack-botandGitHub c7526a197f Merge pull request #4317 from jetstack-bot/cherry-pick-4311-to-release-1.3
[release-1.3] Adds an explicit timeout when pre-checking HTTP-01 challenges
v1.3.3
2021-08-06 12:31:21 +01:00
Ashley Davisandjetstack-bot b922558327 adds an explicit timeout when pre-checking HTTP-01 challenges
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2021-08-06 11:30:06 +00:00
jetstack-botandGitHub 921e1b6967 Merge pull request #4314 from SgtCoDFish/helmchartk8scompat-1.3
[release-1.3] Helm Chart k8s compat update
2021-08-05 18:56:39 +01:00
Ashley Davis 86acb3127f specify correct version range for cert-manager versions below 1.5
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2021-08-05 18:13:07 +01:00
jetstack-botandGitHub 086e5a59a3 Merge pull request #4312 from SgtCoDFish/cherrypick-maintainer-email-1.3
[release-1.3] Update old references to replaced/obsolete email addresses
2021-08-05 15:55:39 +01:00
Ashley Davis 49755fe0c8 update old references to replaced/obsolete email addresses
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2021-08-05 15:42:56 +01:00
jetstack-botandGitHub aa61da4975 Merge pull request #4280 from jetstack-bot/cherry-pick-4231-to-release-1.3
[release-1.3] Data race: fix concurrent read and write of secret annotations and certificaterequests
v1.3.2
2021-07-29 17:30:41 +01:00
jetstack-botandGitHub 2018c5d26a Merge pull request #4279 from SgtCoDFish/cherrypick-memleak-1.3
[release-1.3] Cherry-pick memory leak fixes into 1.3
2021-07-29 16:16:41 +01:00
Maël Valaisandjetstack-bot 6aa769e457 data race: fix certificate requests in cache being mutated
Signed-off-by: Maël Valais <mael@vls.dev>
2021-07-29 15:11:06 +00:00
Maël Valaisandjetstack-bot 42dd6abc53 data race: fix concurrent read and write of secret annotations
This bug can be reproduced using "go run -race" and by creating many
Certificates and renewing them continuously. With 5000 Certificate
objects, a data race is found in less than a minute.

Signed-off-by: Maël Valais <mael@vls.dev>
2021-07-29 15:11:06 +00:00
Maël ValaisandAshley Davis 2ec749674c memory leak: the afterFunc goroutine now stops properly
Signed-off-by: Maël Valais <mael@vls.dev>
2021-07-29 15:58:11 +01:00
Maël ValaisandAshley Davis 4bc106d2b1 memory leak: add unit test to show scheduler leaking goroutines
Signed-off-by: Maël Valais <mael@vls.dev>
2021-07-29 15:58:05 +01:00
jetstack-botandGitHub eaa5f054f9 Merge pull request #4062 from jetstack-bot/cherry-pick-4029-to-release-1.3
[release-1.3] Update to kind 0.11.0/K8s 1.21
2021-05-25 14:57:18 +01:00
Jake Sandersandjetstack-bot 9f328f5941 Update to kind 0.11.0 to e2e test on k8s 1.21
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-25 13:37:38 +00:00
Richard WallandGitHub b508306a0f Merge pull request #4059 from jetstack-bot/cherry-pick-4015-to-release-1.3
[release-1.3] Change default devel K8S_VERSION to 1.20
2021-05-25 14:36:14 +01:00
Irbe KruminaandGitHub 50c497c4ce Merge pull request #4058 from jetstack-bot/cherry-pick-3917-to-release-1.3
[release-1.3] Simplify the installation of sample-external-issuer
2021-05-25 13:34:20 +01:00
Ashley Davisandjetstack-bot f24c2b3565 change default devel K8S_VERSION to 1.20
1.17 is no longer supported by upstream, and 1.21 didn't work with just
a trivial version change, suggesting more work may need to be done

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2021-05-25 11:00:58 +00:00
Richard Wallandjetstack-bot 49da930ffa Simplify the installation of sample-external-issuer
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-05-25 10:12:44 +00:00
jetstack-botandGitHub 614438aed0 Merge pull request #3892 from jetstack-bot/cherry-pick-3878-to-release-1.3
[release-1.3] Set the Ready condition to False when a CertificateRequest has been denied for all CertificateRequests that reference a cert-manager.io signer
v1.3.1
2021-04-13 18:00:11 +01:00
joshvanlandjetstack-bot a60d062871 Remove expected events when Ready Denied condition set
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-13 16:22:57 +00:00
joshvanlandjetstack-bot 41748ea9b3 Don't fire an event when the Denied ready condition is set
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-13 16:22:57 +00:00
joshvanlandjetstack-bot fc4b32b6cf Change Denied CertificateRequest Ready reason to just 'Denied'
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-13 16:22:57 +00:00
joshvanlandjetstack-bot 43f431bc7b Sets the Ready condition to False when a request is Denied
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-13 16:22:57 +00:00
joshvanlandjetstack-bot 97f83bf5af Adds Denied to certificaterequests reporter
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-13 16:22:57 +00:00
joshvanlandjetstack-bot 7f8b9825e2 Adds the RequestDenied Ready condition reason to API
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-13 16:22:57 +00:00
jetstack-botandGitHub 00cb8b67dd Merge pull request #3886 from jetstack-bot/cherry-pick-3882-to-release-1.3
[release-1.3] Certificate's revision history limit validated by webhook
2021-04-12 17:19:08 +01:00
irbekrmandjetstack-bot a248b70427 Certificate's revision history limit validated by webhook
To avoid helm upgrade issues, see https://github.com/jetstack/cert-manager/issues/3880

Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-04-12 14:21:52 +00:00
jetstack-botandGitHub 9c42eeebfd Merge pull request #3818 from SgtCoDFish/securitymd
Add SECURITY.md documenting vuln report process
v1.3.0
2021-04-07 14:47:18 +01:00
jetstack-botandGitHub 9f612f0c2e Merge pull request #3862 from jetstack/revert-3847-fix/3619
Revert "Handle CA issuer working as intermediate correctly"
v1.3.0-beta.0
2021-04-07 09:46:57 +01:00
Maël Valais f56db9f93d Revert "Handle CA issuer working as intermediate" (#3847)
As discussed in #3847, I went too fast and /lgtm from my bed. That led
to having a piece of code that could potentially break people's
cert-manager deployments.

Our plan is to have the same PR re-opened so that we can have it
released for v1.4 (due on Friday 11 June 2021 as per our timeline).

Signed-off-by: Maël Valais <mael@vls.dev>
2021-04-07 10:25:31 +02:00
jetstack-botandGitHub 79ccab3e69 Merge pull request #3847 from erikgb/fix/3619
Handle CA issuer working as intermediate correctly
2021-04-07 07:33:57 +01:00
jetstack-botandGitHub 2dd6b6e224 Merge pull request #3795 from JoshVanL/certificates-issuing-retry-denied-requests
Adds Denied check to CertificateRequests in issuing controller to retry denied requests
2021-04-06 21:34:57 +01:00
jetstack-botandGitHub 10a871dc62 Merge pull request #3444 from maelvls/bug-certificaterequest-not-updated
Bug: certificaterequest not updated after its certificate is updated
2021-04-06 20:17:57 +01:00
jetstack-botandGitHub 6ad91e0700 Merge pull request #3833 from JoshVanL/controller-issuer-context
Pass context through to client calls in controllers and acme issuer
2021-04-06 18:53:57 +01:00
Erik Godding BoyeandErik Godding Boye bbafeeef67 fix #3619: Handle CA issuer working as intermediate correctly
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
2021-04-06 19:45:48 +02:00
Erik Godding BoyeandErik Godding Boye 861db7bf4e Fix minor local dev environment issue
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
2021-04-06 19:45:48 +02:00
Maël ValaisandJosh Soref 8f5a094b0c trigger-controller: PR comment: failure mode -> failure state
Cf. https://github.com/jetstack/cert-manager/pull/3444#pullrequestreview-629189131

Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2021-04-06 19:14:49 +02:00
Maël Valais 181d4ee281 DataForCertificate: typo certitificate -> certificate
Signed-off-by: Maël Valais <mael@vls.dev>
2021-04-06 19:06:21 +02:00
Maël Valais a7486d5025 DataForCertificate: "Failure" CR condition -> "Failed"
Signed-off-by: Maël Valais <mael@vls.dev>
2021-04-06 18:58:31 +02:00
Maël ValaisandJosh Soref 2361f355aa DataForCertificate: PR comment: certificate -> cert-manager certificate
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2021-04-06 18:44:26 +02:00
Maël ValaisandJosh Soref de0de24aad DataForCertificate: PR comment: mode -> state
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2021-04-06 18:42:17 +02:00
Maël ValaisandJosh Soref c875518da1 DataForCertificate: PR comment: mismatch -> does not match
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2021-04-06 18:34:18 +02:00
Maël ValaisandJosh Soref 8b41ec1d54 DataForCertificate: PR comment: distinguish X.509 vs. Kubernetes cert
The cert-manager team tends to use the word "certificate" for two very
different contexts:

1. sometimes, we use the word "certificate" to refer to a X.509
   certificate (a blob of ASN.1-encoded data and then PEM-formated);
2. and sometimes we refer to "certificate" as one item of the Kubernetes
   custom resource /apis/cert-manager.io/v1/certificates.

This commit makes sure the reader understands that we are talking about
the Kubernetes object here.

Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2021-04-06 18:25:48 +02:00
Maël ValaisandJosh Soref a724f1ce31 DataForCertificate: PR comment: mismatches is a noun
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2021-04-06 18:09:59 +02:00
Maël Valais c1d722b116 DataForCertificate: fix diagrams' Failed conditions
Signed-off-by: Maël Valais <mael@vls.dev>
2021-04-06 18:09:59 +02:00
Maël Valais 6c9477439c trigger-controller: hint people to look at gatherer.go diagrams
Signed-off-by: Maël Valais <mael@vls.dev>
2021-04-06 18:09:59 +02:00
Maël Valais 497f561ef7 DataForCertificate: hint people to look at gatherer.go diagrams
Signed-off-by: Maël Valais <mael@vls.dev>
2021-04-06 18:09:59 +02:00
Maël Valais 068a1c466f DataForCertificate: better wording for the "error returned"
Signed-off-by: Maël Valais <mael@vls.dev>
2021-04-06 18:09:59 +02:00
Maël Valais f588d4138a DataForCertificate: explain what the "current" and "next" CRs are used for
Signed-off-by: Maël Valais <mael@vls.dev>
2021-04-06 18:09:47 +02:00
Maël ValaisandJosh Soref a1a43b6784 DataForCertificate: PR comment: explain why we return a "duplicate CR" err
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2021-04-06 18:09:29 +02:00