Commit Graph
5802 Commits
Author SHA1 Message Date
joshvanl 78e77f99db Use correct import for apiextensions in same webhook
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-26 17:46:36 +01:00
joshvanl 5680bfd4b3 Change all CRDs to no longer accept v1beta1 conversionReviewVersions
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-26 17:05:58 +01:00
joshvanl be2ad9ed15 Update sample ACME webhook to use apiextensions v1beta1 -> v1
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-26 17:04:35 +01:00
joshvanl a3cb2b8a41 Update ACME e2e tests to use apiextensions v1beta1 -> v1
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-26 17:03:58 +01:00
joshvanl 12d4246c8a Update ACME clients to use apiextensions v1beta1 -> v1
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-26 17:03:34 +01:00
joshvanl a9aa3b3579 Update ACME webhook API to use apiextensions v1beta1 -> v1
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-26 17:03:14 +01:00
joshvanl 5762b5706e Update Conversion webhook to no longer understand v1beta1, only v1
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-26 17:02:18 +01:00
joshvanl f180f0a0e6 Change internal ACME API to use apiextensions v1beta1 -> v1
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-26 17:00:08 +01:00
joshvanl d87ac770fe Change ACME API to use apiextensions v1beta1 -> v1
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-26 16:59:42 +01:00
jetstack-botandGitHub f278903c4e Merge pull request #4239 from inteon/fix_flakes
Resolve test flakes "the object has been modified"
2021-07-26 14:47:12 +01:00
jetstack-botandGitHub ceb9fdf6ac Merge pull request #4231 from maelvls/fix-concurrent-read-write
Data race: fix concurrent read and write of secret annotations and certificaterequests
2021-07-26 13:34:12 +01:00
jetstack-botandGitHub 218408a741 Merge pull request #4112 from JoshVanL/certificate-signing-request=acme
CertificateSigningRequest ACME Controller
2021-07-26 11:51:12 +01:00
jetstack-botandGitHub 1021b58286 Merge pull request #4233 from maelvls/goroutine-leak
Memory leak: fix the scheduler's goroutine leakage
2021-07-23 20:34:19 +01:00
joshvanl 247807162f Expect event fired when ACME CSR request is not yet approved
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-23 16:34:21 +01:00
jetstack-botandGitHub 77c5c2fb16 Merge pull request #4184 from inteon/kubectl_certmanager_install_tests
Add basic tests to kubectl cert-manager x install
2021-07-23 16:16:19 +01:00
joshvanl a81ba4fcb3 Change test name to make it clear it is not a duplicate
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-23 16:10:35 +01:00
joshvanl e18e29ea45 Adds unit tests for CertificateSigningRequest ACME handle owner
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-23 16:00:09 +01:00
joshvanl 9e322a4033 Removes old comment which is no longer relevant
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-23 16:00:09 +01:00
joshvanl b84e3edcc9 Review comments
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-23 16:00:09 +01:00
joshvanl bec5d5be32 Remove CA annotation from ACME CertificateSigningRequest controller
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-23 16:00:09 +01:00
joshvanl 2a1952c918 Adds ACME CSR to E2E conformance test suite
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-23 16:00:09 +01:00
joshvanl 1284f358d0 Adds missing required feature to CommonName CSR E2E test
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-23 16:00:09 +01:00
joshvanl c9f5cbd0bc Adds more modifier funcs to Order in unit gen
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-23 16:00:09 +01:00
joshvanl b041a8fb3d Wires up ACME CSR controller
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-23 16:00:09 +01:00
joshvanl 43f002b0f0 Adds CertificateSigningRequest ACME controller
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-23 16:00:09 +01:00
Maël Valais 641960b666 memory leak: clean up scheduler goroutine on certificate deletion
Signed-off-by: Maël Valais <mael@vls.dev>
2021-07-23 16:57:10 +02:00
Inteon 0ed0135930 Improvements based on reviewer's feedback
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-07-23 15:29:43 +02:00
jetstack-botandGitHub 9ad9e220f3 Merge pull request #4230 from inteon/fix_exit_codes
set correct exit codes
2021-07-23 13:06:09 +01:00
jetstack-botandGitHub 3ee37e893d Merge pull request #4229 from JoshVanL/certificate-signing-request=event-not-approved
Fire event when CertificateSigningRequest hasn't been Approved yet
2021-07-23 12:23:08 +01:00
jetstack-botandGitHub 5ebcbced5c Merge pull request #4240 from irbekrm/k8s_1_22
Adds an option to build k8s 1.22 kind cluster
2021-07-23 09:26:09 +01:00
irbekrm 5edad74e8a Ensure jq is available
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-07-22 20:53:39 +01:00
Inteon 50daf04118 rename cmdutil to k8scmdutil
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-07-22 21:43:53 +02:00
Maël Valais 62bc854467 e2e: sample-external-issuer v0.1.0 -> v0.1.1 (1.22 compatibility)
Signed-off-by: Maël Valais <mael@vls.dev>
2021-07-22 21:13:39 +02:00
irbekrm 63873ab8a9 Bump e2e test NGINX ingress Helm chart version
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-07-22 20:08:05 +01:00
irbekrm 5e83e35b7c Allow for ./setup-e2e-deps.sh script to be run locally against k8s v1.22
Without specifying Kubernetes version

Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-07-22 20:07:37 +01:00
irbekrm 84f653f01f e2e test setup installs a different version of Ingress depending on k8s version
This is needed because there are no NGINX ingress release that would support work both on k8s v1.16-v1.18 as well as v1.22

Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-07-22 19:35:57 +01:00
irbekrm 00542dd7f6 Bump apiregistration API version to v1
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-07-22 17:19:27 +01:00
irbekrm 69afd75e9a Adds an option to build k8s 1.22 kind cluster
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-07-22 16:08:22 +01:00
Inteon c377e0e0cd add comments
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-07-22 13:08:11 +02:00
Inteon d6cd6f457d set correct exit codes when exiting
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-07-22 12:57:08 +02:00
Inteon ac677964c1 resolve test flakes 'the object has been modified'
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-07-22 10:10:39 +02:00
jetstack-botandGitHub 05cfd7bb72 Merge pull request #4218 from inteon/verify_upgrade_use_check_api
Use 'kubectl cert-manager check api' in verify-upgrade.sh
2021-07-21 20:37:20 +01:00
jetstack-botandGitHub 8ea29ba49a Merge pull request #4237 from SgtCoDFish/parsechaintest
Fix check for self-signed certs in EncodeX509Chain
2021-07-21 17:49:20 +01:00
Ashley Davis 17ec9ea8e7 fix check for self-signed certs in EncodeX509Chain
see also https://github.com/jetstack/cert-manager/issues/4142

EncodeX509Chain checked for self-signed certs by comparing the subject
and issuer of the cert in question, which is invalid since it's
perfectly fine for those to match.

the correct behavior is to use cert.CheckSignatureFrom(cert). this bug
was exposed in 1.4 when ParseSingleCertificateChain started using
EncodeX509Chain in the critical path of several issuers; when end-users
had leaf certificates with subjects matching their issuer's subject, the
bug was triggered.

includes newly written tests for EncodeX509Chain and a test for
ParseSingleCertificateChain

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2021-07-21 16:45:48 +01:00
jetstack-botandGitHub f489c7df02 Merge pull request #4236 from irbekrm/fix_version_finding
Fix how last published release version is calculated for upgrade tests
2021-07-21 15:15:20 +01:00
Ashley DavisandGitHub 31360580f0 Merge pull request #4232 from SgtCoDFish/cabasicconstraint_e2e
CA Basic Constraint checks in e2e tests
2021-07-21 14:10:03 +01:00
irbekrm 48d4f955ea Fix how last published release is calculated
It should always be the last published non-alpha/beta release

Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-07-21 13:58:44 +01:00
Maël Valais 8e872632f4 memory leak: the afterFunc goroutine now stops properly
Signed-off-by: Maël Valais <mael@vls.dev>
2021-07-21 10:25:56 +02:00
Maël Valais eb947f98ea memory leak: add unit test to show scheduler leaking goroutines
Signed-off-by: Maël Valais <mael@vls.dev>
2021-07-21 10:25:49 +02:00
Maël Valais af9a1e434f data race: fix certificate requests in cache being mutated
Signed-off-by: Maël Valais <mael@vls.dev>
2021-07-20 19:50:26 +02:00