home/cert-manager
2
0
Fork 0
mirror of https://github.com/wahyd4/cert-manager.git synced 2026-08-09 05:06:38 +10:00
Code Issues Packages Projects Releases Wiki Activity
6,020 Commits 37 Branches 119 Tags
b2f7aa57ea6889965193b14eadaa4e76ffc855ab
Commit Graph
6020 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Ashley Davis b2f7aa57ea remove krew automation 
github actions is pretty flawed in several ways, and it's missing
features which would make it usable for us.

we want to trigger our krew automation when a new stable release of our
latest supported cert-manager release is published. github has all this
information, but it's not easy to _use_ that information when triggering
a github action.

we also only want to trigger the action on the main repo and not on
forks.

if we end up having to write custom code to do this, we might as well
add that code into cmrel and not have to deal with the flaws in gh
actions.

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
 2021-08-24 11:24:52 +01:00
jetstack-botandGitHub e5cc0be04b Merge pull request #4399 from irbekrm/fix_renewal_issue 
Fix renewalTime skew issue
 2021-08-23 16:36:50 +01:00
irbekrm ec1bdc4983 Adds a test case for renewal time skew and a comment 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-23 15:00:57 +01:00
jetstack-botandGitHub 38338bc7c3 Merge pull request #4402 from Juneezee/deprecate-ioutil 
refactor: move from io/ioutil to io and os package
 2021-08-23 13:50:51 +01:00
Eng Zer Jun 54e70d2cc4 refactor: move from io/ioutil to io and os package 
The io/ioutil package has been deprecated in Go 1.16. This commit
replaces the existing io/ioutil functions with their new definitions in
io and os packages.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
 2021-08-23 19:50:42 +08:00
irbekrm 50e90dfe6e Fix renewalTime skew issue 
Ensure the time returned by RenewalTime function is the same time as that which will be read from Certificate's status

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-20 17:57:35 +01:00
jetstack-botandGitHub 38ab6f4bdd Merge pull request #4365 from jonathansp/master 
fix: flaky test when comparing unordered elements
 2021-08-20 13:02:44 +01:00
jetstack-botandGitHub 0ff741c9d2 Merge pull request #4392 from SgtCoDFish/fixversions 
Fix manually specified Certificate and CertificateRequest versions
 2021-08-20 12:16:45 +01:00
jetstack-botandGitHub 72f5694659 Merge pull request #4393 from jakexks/solver_serviceType 
Regression: restore the previous service type defaulting behaviour
 2021-08-19 15:36:09 +01:00
Jake Sanders 5df1dd4932 Update Docs on solver type to reflect default service type 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-08-19 14:55:50 +01:00
Jake Sanders f1ac6efade Add integration test for ensuring default solver service type is NodePort 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-08-19 14:52:23 +01:00
Jake Sanders 326783ca32 Fix regression in solver service builder - default service type should be NodePort rather than empty 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-08-19 14:51:21 +01:00
Ashley Davis 68f5ceb3b4 Fix manually specified Certificate and CertificateRequest versions 
Basically all modern X.509 certs are version 3, but confusingly to
specify "version 3" in an encoded cert, the version number is actually
2.

For PKCS#10 CSRs, the only valid version is 1, which again
confusingly has the value "0" when encoded.

This was incorrect in many places, including one place in which the
version number on a CSR was used as a certificate's version number,
when the two are entirely unrelated.

Go ignores these values, so there's no functional changes here; still,
it's better to be accurate.

Go ignoring CSR version and specifying 0:
https://cs.opensource.google/go/go/+/refs/tags/go1.17:src/crypto/x509/x509.go;l=1958

Go ignoring Certificate version and specifying 2:
https://cs.opensource.google/go/go/+/refs/tags/go1.17:src/crypto/x509/x509.go;l=1534

PKCS#10 CSR specification in RFC 2986 section 4.1:
https://datatracker.ietf.org/doc/html/rfc2986#section-4

X.509 Cert specification in RFC 5280 section 4.1.2.1:
https://datatracker.ietf.org/doc/html/rfc5280#section-4.1.2.1

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
 2021-08-19 14:48:12 +01:00
jetstack-botandGitHub c24c0889bf Merge pull request #4390 from irbekrm/verify_crd_status 
Verify crd status
 2021-08-19 10:22:08 +01:00
Irbe KruminaandAshley Davis e43db8a426 Code review feedback. 
Co-authored-by: Ashley Davis <SgtCoDFish@users.noreply.github.com>
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-19 09:43:45 +01:00
irbekrm 04b584e698 verify-crds script now verifies that the CRDs don't contain status field 
This is necessary because some CD tools don't accept resource configs with predefined status fields, but controllergen currently adds this field when a CRD yaml is generated

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-19 06:19:37 +01:00
irbekrm b8e2846901 Adds a Bazel rule to install yq 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-18 18:36:01 +01:00
jetstack-botandGitHub a608e850de Merge pull request #4386 from jakexks/gnu-sed 
Fix codegen script on Darwin
 2021-08-18 18:06:29 +01:00
jetstack-botandGitHub c5a4cb9fbf Merge pull request #4384 from jakexks/en_GB 
finalisers -> finalizers
 2021-08-18 17:23:35 +01:00
jetstack-botandGitHub bea6c20e26 Merge pull request #4369 from irbekrm/improve_owner_not_found_errors 
Improve owner not found errors
 2021-08-18 17:23:29 +01:00
jetstack-botandGitHub ba2e25674a Merge pull request #4379 from irbekrm/remove_crd_status 
Removes status fields from CRD definitions
 2021-08-18 16:42:29 +01:00
Jake Sanders 682b3f108e Fix sed command on Darwin 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-08-18 16:09:14 +01:00
jetstack-botandGitHub 18a15fe385 Merge pull request #4373 from jakexks/ingress_path_type 
Fix regression in ACME HTTP-01 Ingress Solver introduced in v1.5.0
 2021-08-18 15:55:28 +01:00
Jake Sanders e0ecc9938a finalisers -> finalizers 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-08-18 15:33:27 +01:00
Jake Sanders 38ce03e3ec Fix regression in Ingress PathType introduced in v1.5.0 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-08-18 15:16:23 +01:00
jetstack-botandGitHub 00679a557b Merge pull request #4383 from irbekrm/vcloud_v2 
Explicitly set Venafi Cloud e2e tests to use v2 endpoint
 2021-08-18 15:15:29 +01:00
irbekrm 831b87898f Explicitly set Venafi Cloud e2e tests to use v2 endpoint 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-18 12:52:05 +01:00
irbekrm 7d30a6452c Removes status fields from CRD definitions 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-18 10:17:34 +01:00
irbekrm 904d4e3c15 Don't error if owner not found in cache 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-17 08:31:49 +01:00
jetstack-botandGitHub ff9403aaf2 Merge pull request #4366 from SgtCoDFish/krew_darwin_arm64 
update trigger for gh action, add arm64 darwin for krew
 2021-08-16 19:05:02 +02:00
Ashley Davis b069056e0a update trigger for gh action, add arm64 darwin for krew 
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
 2021-08-16 17:21:07 +01:00
Jonathan Prates 1ff50d3dd8 fix: flaky test when comparing unordered elements 
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
 2021-08-16 15:04:01 +01:00
jetstack-botandGitHub b5003b52d0 Merge pull request #4359 from johanfleury/feature/make-leader-election-defaults-consistent 
Make leader election defaults consistent
 2021-08-14 05:08:14 +02:00
jetstack-botandGitHub 30c40f8f15 Merge pull request #4348 from inteon/upgrade_deps_v0.22.0 
Upgrade deps (kube v0.22.0)
 2021-08-14 01:07:12 +02:00
jetstack-botandGitHub e608995101 Merge pull request #4363 from inteon/fix_4350 
rerun git tags command when //:version changes
 2021-08-14 00:02:11 +02:00
Inteon b13eb0483b upgrade deps to latest version (kube v0.22.0) 
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
 2021-08-13 23:38:59 +02:00
Inteon e439749e92 rerun git tags command when //:version changes 
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
 2021-08-13 22:59:38 +02:00
Johan Fleury ef32714434 Make leader election defaults consistent 
Signed-off-by: Johan Fleury <jfleury@arcaik.net>
 2021-08-13 12:14:40 -04:00
jetstack-botandGitHub 54c66769bc Merge pull request #4353 from SgtCoDFish/beta1dnscrds 
Fix mistakenly changed CRDs for v1beta1
 2021-08-13 15:40:11 +02:00
Ashley Davis e0e5a50f31 fix mistakenly changed CRDs for v1beta1 (#4352) 
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
 2021-08-13 13:44:05 +01:00
jetstack-botandGitHub 9d1c6c9f09 Merge pull request #4347 from inteon/fix_install 
Don't wait for hooks in kubectl cert-manager x install integration test (part 2)
 2021-08-13 09:36:11 +02:00
jetstack-botandGitHub 57c5c11260 Merge pull request #4335 from inteon/cleanup_integration_tests 
Integration tests cleanup
 2021-08-13 08:56:11 +02:00
Inteon f4bc283965 update comments 
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
 2021-08-12 22:54:14 +02:00
Inteon 91ec4c773a use correct contexts everywhere & don't restart apiserver to add crds 
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
 2021-08-12 20:05:01 +02:00
jetstack-botandGitHub 720ffaf6ac Merge pull request #4341 from irbekrm/official_kind_image 
Use the official kind image for testing against Kubernetes v1.22
 2021-08-12 11:17:43 +02:00
jetstack-botandGitHub 6f37d33c33 Merge pull request #4342 from inteon/fix_install 
Don't wait for hooks in `kubectl cert-manager x install` integration test
 2021-08-12 10:06:42 +02:00
Inteon e5df60d47e don't wait for hooks in kubectl cert-manager x install test & use local chart for tests 
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
 2021-08-11 23:18:33 +02:00
irbekrm 5f1d5df792 Use the official kind image for testing against Kubernetes v1.22 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-11 15:06:53 +01:00
jetstack-botandGitHub 4f61d405a6 Merge pull request #4336 from irbekrm/fix_upgrade_tests 
Fix upgrade tests
 2021-08-11 10:48:13 +01:00
jetstack-botandGitHub a045a70cce Merge pull request #4327 from SgtCoDFish/reenable-venafi 
Re-enable venafi tests
 2021-08-11 10:09:12 +01:00