home/cert-manager
2
0
Fork 0
mirror of https://github.com/wahyd4/cert-manager.git synced 2026-08-13 15:15:55 +10:00
Code Issues Packages Projects Releases Wiki Activity
4,804 Commits 37 Branches 119 Tags
c195417ffad3d484e8f56cb79b1e92ede7bbce99
Commit Graph
4804 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
jetstack-botandGitHub c195417ffa Merge pull request #3487 from meyskens/rm-legacy 
Remove the legacy release
 2020-12-09 11:53:16 +01:00
Maartje Eyskens 22aa9e89fa Comment on why the variants are there 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-09 11:22:05 +01:00
Maartje Eyskens 4ef0de99b9 Remove lost section of legacy 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-09 11:22:05 +01:00
jetstack-botandGitHub 7c53f88f19 Merge pull request #3476 from maelvls/unit-test-backoff-one-hour 
Move the 'back off for 1 hour' logic to a unit-tested func
 2020-12-08 11:02:17 +01:00
jetstack-botandGitHub 2520ed6ab4 Merge pull request #3478 from maelvls/fix-issuing-controller-not-waiting-request-match 
Bug: the issuing controller does not wait until the request matches the certificate before setting the certificate to "Issuing = False"
 2020-12-08 10:30:17 +01:00
Maël Valais 62f8db6e6a refactor(issuing): PR review: use MustCreateCryptoBundle directly 
Signed-off-by: Maël Valais <mael.valais@gmail.com>
 2020-12-06 14:22:02 +01:00
Maël Valais 6484010f5c fix(issuing): wait until req matches cert before setting failure 
The issuing controller wasn't checking if the certificate request that
it picked up is up to date. That resulted in the certificate being set
to "Failing" and "Issuing = False" due to an old certificate request
that was created during a previous issuance. The certificate would then
become stale.

Signed-off-by: Maël Valais <mael.valais@gmail.com>
 2020-12-06 14:22:02 +01:00
Maël Valais 17cd05ecab test(issuing): new test: when req mismatches, cert can't be updated 
This new unit test highlights an unexpected behavior of the issuing
controller: the issuing controller is updating the certificate's status
when the certificate request has a failure ("Reason = Failed"), but the
controller might have picked up an out-of-date certificate request.

The consequence is that the issuing controller would set the certificate
to "Issuing = False". That happens when a re-issuance is triggered with
an old failing certificate request.

Signed-off-by: Maël Valais <mael.valais@gmail.com>
 2020-12-06 14:22:02 +01:00
Maël Valais 07fd8754f5 refactor(trigger): add test case when failure just happened 
Signed-off-by: Maël Valais <mael.valais@gmail.com>
 2020-12-06 13:51:12 +01:00
Maël Valais 769303c5f8 refactor(trigger): don't backoff when exactly 60min 
As Maartje mentioned, it doesn't make sense to return backoff = true
while returning a delay of 0. Also, use time.UTC instead of time.Local.

Signed-off-by: Maël Valais <mael.valais@gmail.com>
 2020-12-06 13:44:06 +01:00
Maël Valais 27d4924b5a refactor(trigger): move backoff logic to a unit-tested func 
The trigger_controller_test.go has many unrelated test cases and I
thought it would be good to have more tightly scoped functions that are
easy to review (and most importantly, the unit tests are easy to
review).

Signed-off-by: Maël Valais <mael.valais@gmail.com>
 2020-12-06 13:40:01 +01:00
jetstack-botandGitHub 0bcf759a25 Merge pull request #3433 from sorah/vault-issuer-exclude-root 
Handle Vault issuer working as intermediate correctly
 2020-12-03 09:23:14 +01:00
jetstack-botandGitHub fe84c50f7b Merge pull request #3485 from maelvls/bug-spurious-updates-aws 
Strip X-Amzn-RequestId to avoid spurious challenge updates
 2020-12-02 15:42:33 +01:00
Maartje EyskensandGitHub 8b84a801e0 Update deploy/charts/cert-manager/README.template.md 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-02 15:13:07 +01:00
Maartje Eyskens 3a2f02f0e3 Fix old CRD reference 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-02 15:01:17 +01:00
Maartje Eyskens 136f332fcb fix location 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-02 14:38:35 +01:00
Maartje Eyskens 006981e7e5 Format bazel 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-02 14:13:45 +01:00
Maartje Eyskens fb1ee4c952 Fix static manifests 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-02 14:05:22 +01:00
Maartje Eyskens 71b75d3644 Fix CRDs in helm lint 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-02 13:30:14 +01:00
Maartje Eyskens f33c63e901 Fix a lost variable + format 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-02 11:25:01 +01:00
Maartje Eyskens 51c86437b2 Add correct CRD source 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-02 11:19:24 +01:00
Maartje Eyskens f14d695888 Fix chart files 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-02 11:16:37 +01:00
Maartje Eyskens 5c12dd11aa Fix src 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-01 16:55:42 +01:00
Maartje Eyskens ff76fe3a28 Fix CRD targets 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-01 16:43:16 +01:00
Maartje Eyskens eb3c0f8448 Fix syntax error 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-01 16:32:07 +01:00
Maartje Eyskens 887af1bc84 Remove the legacy release 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-01 16:17:07 +01:00
Maël Valais 8d8dd02245 dns01-aws: aws-sdk-go already honors the proxy settings 
No need for setting http.DefaultClient manually.

Signed-off-by: Maël Valais <mael.valais@gmail.com>
 2020-12-01 13:26:29 +01:00
jetstack-botandGitHub 6fd14b0241 Merge pull request #3464 from wallrj/3396-renew-before-expiry-duration 
Fix and deprecate the --renew-before-expiration-duration flag
 2020-12-01 12:07:06 +01:00
Maël Valais 8a5748be94 dns01-aws: strip request id from aws errors 
Signed-off-by: Maël Valais <mael.valais@gmail.com>
 2020-12-01 11:11:05 +01:00
Maël Valais cccc0b1d4d dns01-aws: add test that reveals the request id issue 
Signed-off-by: Maël Valais <mael.valais@gmail.com>
 2020-11-30 13:31:12 +01:00
Sorah Fukumori f768afd0a3 vault: change condition precise 
Signed-off-by: Sorah Fukumori <her@sorah.jp>
 2020-11-28 18:13:49 +09:00
Sorah FukumoriandMaartje Eyskens 90c4f9e561 Avoid named return variables 
Co-authored-by: Maartje Eyskens <maartje@eyskens.me>
Signed-off-by: Sorah Fukumori <her@sorah.jp>
 2020-11-28 18:06:49 +09:00
jetstack-botandGitHub 7fbdd64876 Merge pull request #3347 from meyskens/acme-duration 
Add duration into ACME
v1.1.0 		2020-11-24 10:37:01 +01:00
Maartje Eyskens a869c59cb7 Remove internal API tags and annotations 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-11-20 13:42:24 +01:00
jetstack-botandGitHub 92f4d7d349 Merge pull request #3384 from meyskens/no-acme-retry 
Disable Go's ACME retry logic
 2020-11-20 11:31:54 +00:00
Maartje Eyskens d705838e83 Implement feedback 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-11-20 09:46:49 +01:00
Maartje Eyskens 66f787ef33 Fix a lost EnableNotAfterDate 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-11-20 09:46:49 +01:00
Maartje Eyskens 9559a71301 Update CRDs 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-11-20 09:46:49 +01:00
Maartje Eyskens b7014c3dbd Fix rename in json too 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-11-20 09:46:49 +01:00
Maartje Eyskens 59048fed64 Rename field 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-11-20 09:46:49 +01:00
Maartje Eyskens 04d88479e4 Pass duration on until ACME order creation 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-11-20 09:46:49 +01:00
Maartje Eyskens 1b33e8029a Fix unit tests 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-11-20 09:46:08 +01:00
Maartje Eyskens 7b6573aa35 Add duration into ACME 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-11-20 09:45:32 +01:00
Richard Wall 1fc1fa88a0 Prevent instant renewal when the renewBefore value matches the duration 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-11-19 15:00:27 +00:00
Richard Wall 95a229cc6e Unit tests for current behaviour 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-11-19 13:01:00 +00:00
Richard Wall a33abd2060 Plumb through the flag provided defaultRenewBeforeExpiryDuration 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-11-19 12:44:18 +00:00
Richard Wall cc1412b252 Deprecate the --renew-before-expiry-duration flag 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-11-19 12:44:18 +00:00
Richard Wall 2b83331a2d Remove unused helper functions 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-11-19 12:44:18 +00:00
jetstack-botandGitHub 811b67bb8c Merge pull request #3456 from meyskens/pebble-blocklist 
Add a blocklist to Pebble
 2020-11-19 11:03:53 +00:00
Maartje Eyskens 490f18b5ff Use upstream Pebble again 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-11-19 10:44:22 +01:00