home/cert-manager
2
0
Fork 0
mirror of https://github.com/wahyd4/cert-manager.git synced 2026-08-23 03:56:34 +10:00
Code Issues Packages Projects Releases Wiki Activity
5,204 Commits 37 Branches 119 Tags
dc99a5e8ca5c9f038c19aeed8e982c86dafef77f
Commit Graph
5204 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Maël ValaisandIrbe Krumina dc99a5e8ca acme-http01-e2e: PR comment: Equal -> ContainElements for DNS names 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Irbe Krumina <irbekrm@gmail.com>
 2021-04-06 18:09:28 +02:00
Maël ValaisandIrbe Krumina 6cda600e42 acme-http01-e2e: PR comment: 30 seconds of wait is enough 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Irbe Krumina <irbekrm@gmail.com>
 2021-04-06 18:09:28 +02:00
Maël ValaisandIrbe Krumina 98fe26b939 acme-http01-e2e: PR comment: check cert is unready before correcting it 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Irbe Krumina <irbekrm@gmail.com>
 2021-04-06 18:09:28 +02:00
Maël ValaisandJosh Soref 85128f26ce trigger-controller: PR comment: rephrase log about skipping issuance 
The log message:

    multiple CertificateRequests found for the 'next' revision 2,
    skipping issuance until no more duplicate.

can be better phrased as:

    multiple CertificateRequests are found for the 'next' revision 2,
    issuance is skipped until there are no more duplicates.

Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
 2021-04-06 18:09:28 +02:00
Maël ValaisandJosh Soref 05c1fb9fc2 trigger-controller: reissue on mismatch using NextRevisionRequest 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
 2021-04-06 18:09:28 +02:00
Maël ValaisandJosh Soref eb6d1399fc DataForCertificate: the func now fetches NextRevisionRequest 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
 2021-04-06 18:09:27 +02:00
Maël ValaisandJosh Soref 9305766ff2 trigger-controller: add two unit tests to showcase #3250 
Note that I had initially made createCryptoBundle public since I found
it inconvenient to have to pass a testing.T when we know that we should
never be  failing inside this func (I mean, the failure  zould not be due
to a wrong test case).

After a comment from Maartje, I realize that I could just use an anonymous
function for that purpose.

Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
 2021-04-06 18:09:27 +02:00
Maël ValaisandJosh Soref 3832f551aa acme-http01-e2e: "validations" are not actually verifying the X.509 cert 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
 2021-04-06 18:09:27 +02:00
Maël ValaisandJosh Soref 78e2e7fdca acme-http01-e2e: pebble was returning the same 400 as boulder 
Pebble:

  400 urn:ietf:params:acme:error:rejectedIdentifier: Order included an identifier for which issuance is forbidden by policy: "google.com"

Let's Encrypt's boulder:

  400 urn:ietf:params:acme:error:rejectedIdentifier: Cannot issue for "google.com"

Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
 2021-04-06 18:09:27 +02:00
Maël ValaisandJosh Soref 18a9461023 acme-http01-e2e: add a test case to show the cert update bug 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
 2021-04-06 18:09:27 +02:00
Maël ValaisandJosh Soref 89c3dc1afa gen: document why we do not pass an entire Certificate 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
 2021-04-06 18:09:27 +02:00
Maël ValaisandJosh Soref 747aba056c createCryptoBundle: cert-manager.io/certificate-revision was wrong 
It was set to a pointer value instead of the actual int value.

Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
 2021-04-06 18:09:27 +02:00
jetstack-botandGitHub 2abafa18be Merge pull request #3846 from irbekrm/reinstate_line_wrapping 
Reinstate line wrapping
 2021-04-03 17:02:51 +01:00
irbekrm 22f6cb18d2 Adds some comments 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-04-03 15:54:52 +01:00
irbekrm 245d591dc3 reinstate line wrapping 
by bumping gopkg.in/yaml to v2.4.0

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-04-03 15:39:04 +01:00
jetstack-botandGitHub e3ae071f1c Merge pull request #3823 from irbekrm/bump_go 
Bumps go 1.15 -> 1.16
 2021-04-03 09:10:48 +01:00
irbekrm 62d4fb7384 Bumps go 1.15 -> 1.16 
Signed-off-by: irbekrm <irbekrm@gmail.com>

Runs ./hack/update-deps.sh

Signed-off-by: irbekrm <irbekrm@gmail.com>

get go_rules to download latest patch version of go

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-04-02 10:21:39 +01:00
jetstack-botandGitHub c2c0fdd781 Merge pull request #3831 from wallrj/3642-venafi-cloud-outage-predict 
Upgrade to vcert 4.13.1
v1.3.0-alpha.1 		2021-04-01 13:30:39 +01:00
jetstack-botandGitHub 5dd00bf2a5 Merge pull request #3815 from RinkiyaKeDad/3796_e2e_fail_logs 
feat: fix logs display for e2e test failures
 2021-04-01 09:36:39 +01:00
Richard Wall 39ebccd0ba Skip the Venafi Cloud conformance tests by default 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-04-01 09:13:36 +01:00
Richard Wall a372e1afb6 Delete empty Venafi Cloud issuer tests 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-04-01 09:13:36 +01:00
Richard Wall 308a0f4405 Upgrade to vcert 4.13.1 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-04-01 09:13:36 +01:00
jetstack-botandGitHub e29a3df86d Merge pull request #3785 from JoshVanL/approval-subject-access-review 
Approval subject access review
 2021-04-01 08:00:39 +01:00
joshvanl 46f1d853f5 Adds comment about why we convert CRs into internal types when 
validating approval

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-30 15:33:27 +01:00
jetstack-botandGitHub 517d211103 Merge pull request #3816 from irbekrm/update_bazel 
Bump versions of Gazelle, go_rules, Kazel, protobuf
 2021-03-30 13:44:38 +01:00
RinkiyaKeDad a5580a9ab7 feat: removed exit 
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
 2021-03-30 16:46:51 +05:30
RinkiyaKeDad 79ee98bb56 feat: running the jobs in series 
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
 2021-03-30 16:03:19 +05:30
jetstack-botandGitHub 45befd8696 Merge pull request #3811 from salmanahmed404/SemanticChecks-3809 
Replace reflect.DeepEqual with semantic equality check
 2021-03-29 09:40:32 +01:00
irbekrm 81a8588b91 Bumps versions of Gazelle, go_rules, Kazel, protobuf 
Signed-off-by: irbekrm <irbekrm@gmail.com>

Bumps versions of Gazelle, go_rules, Kazel and protobuf

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-03-29 08:25:12 +01:00
RinkiyaKeDad 45f1507a76 feat: fix logs display for e2e test failures 
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
 2021-03-27 16:53:52 +05:30
Salman 800d6019bf Replace reflect.DeepEqual with semantic equality check and remove status marshal 
Signed-off-by: salmanahmed404 <salmanahmed404@gmail.com>
 2021-03-27 12:49:14 +05:30
Salman 572bfb9111 Replace reflect.DeepEqual with semantic equality check 
Signed-off-by: salmanahmed404 <salmanahmed404@gmail.com>
 2021-03-27 12:49:14 +05:30
joshvanl 820b8556a3 Fix go linting 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:41:42 +00:00
joshvanl 55e74c3e02 Update bazel build files 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:28:14 +00:00
joshvanl 191e448764 Updates go modules 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl f8b38daa4c Update cert-manager-controller:approve RBAC naming to be more consistent 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl 56a604c6f0 Init plugins in webhook cmd 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl b75655fbb6 Updates approval e2e tests to include custom resource definitions 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl 4be73eaec0 Add plugins to webhook server 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl 3ecef47b2a Remove SubjectAccessReview validation registry 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl 29a7a90d85 Remove old approval SAR registry 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl 8380569470 Move approval validation to new internal webhook admission plugin 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl 109b3e0b28 Rename Wehook's API server host flag from --master to --api-server-host 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl 746cd7460b Updates approval review comment to correctly state cluster scope and 
issuer name

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl d69e798b83 Update validation approved tests for new string 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl 5b34d9a6cc Change cert-manager-controller approve RBAC resource names to 
':approve-cert-manager-io'

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl 393848ee98 Fix webhook RBAC resource names to use ':subjectaccessreviews' 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl ed22fb99f6 Change approved/denied forbidden error to read better for EU 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl a97be01bd8 Adds test comment to approval e2e test 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl 8048034b0e Adds permissions to approve "issuer.cert-manager.io/*", "clusterissuer.cert-manager.io/*" signers to the cert-manager-controller ServiceAccount 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00