Commit Graph
4950 Commits
Author SHA1 Message Date
jetstack-botandGitHub eced645c8d Merge pull request #3652 from 7opf/patch-1
use port from helm value for service targetPort
2021-03-02 11:40:43 +00:00
jetstack-botandGitHub 4a99b15f5a Merge pull request #3710 from johejo/fix_build_on_go116
Fix build on go1.16
2021-03-02 11:20:43 +00:00
jetstack-botandGitHub 67091a6071 Merge pull request #3707 from jakexks/kubectl-secret-test-fix
Fix expired certificate test in kubectl plugin
2021-03-02 09:51:43 +00:00
jetstack-botandGitHub a9c672e900 Merge pull request #3699 from maelvls/ocsp-unit-test
Add unit tests around the new ocspServers field
2021-03-01 19:12:49 +00:00
Zee MarshandGitHub 5b84746baf Merge pull request #3722 from jetstack/add-owners
Add Irbe and Mael to the OWNERS list
2021-03-01 17:53:25 +00:00
a1851f0542 Add Irbe and Mael to the OWNERS list
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: irbekrm <irbekrm@gmail.com>
2021-03-01 18:05:54 +01:00
Maël ValaisandIrbe Krumina e7b3e6c4e5 PR comment: no more "return" in test code
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Irbe Krumina <irbekrm@gmail.com>
2021-03-01 14:12:02 +01:00
Mitsuo Heijo ffa79f6b8d Fix build on go1.16
Signed-off-by: Mitsuo Heijo <mitsuo.heijo@gmail.com>
2021-02-26 22:47:56 +09:00
Jake Sanders 4c935a2706 Fix expired certificate test
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-02-26 11:06:25 +00:00
Maël ValaisandIrbe Krumina dc4f0a34e9 PR comment: compare time.Time instead of strings
Also removed the unused "givenNamespace"

Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Irbe Krumina <irbekrm@gmail.com>
2021-02-25 10:28:56 +01:00
jetstack-botandGitHub 95f8d53e19 Merge pull request #3700 from alrs/alrs-fix-acme-test
pkg/controller/certificaterequests/acme: fix dropped test error
2021-02-24 18:08:53 +00:00
Maël ValaisandIrbe Krumina e50f26fc97 PR comment: fix notAfter test case using time.Truncate
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Irbe Krumina <irbekrm@gmail.com>
2021-02-24 15:07:54 +01:00
Maël Valais c9dcae2313 ocspServers field: add unit test
Signed-off-by: Maël Valais <mael@vls.dev>
2021-02-24 11:05:59 +01:00
Lars Lehtonen 0270377f6c pkg/controller/certificaterequests/acme: fix dropped test error
Signed-off-by: Lars Lehtonen <lars.lehtonen@gmail.com>
2021-02-23 18:13:37 -08:00
jetstack-botandGitHub a43e3309c2 Merge pull request #3693 from irbekrm/3683_remove_renew_before_expiry_flag
Removes the deprecated renew-before-expiry flag
2021-02-22 11:50:47 +01:00
7opfandSeverin Skillman 5dc0eba59d use port from helm value for service targetPort
Signed-off-by: Severin Skillman <sev@skillman.ch>
2021-02-21 12:26:07 +00:00
irbekrm b852e97ffb Removes the deprecated renew-before-expiry flag
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-02-21 10:22:25 +00:00
jetstack-botandGitHub a2427c5b45 Merge pull request #3679 from wallrj/tpp-testing
Label all the Venafi TPP tests so that they can be run in a separate, non-merge-blocking, prow job
2021-02-19 12:10:37 +01:00
Richard Wall bc16ec8941 Mark Venafi E2E tests as separate Feature: group
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-02-18 18:15:36 +00:00
Richard Wall f7b80ea2b2 Skip tests containing the labels [Flaky] or [Feature:xyz]
This will allow us to skip certain known Flaky tests without having to modify
the testing infra.
And it will allow us to target these tests from a separate test job,
when we DO want to run them.

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-02-18 15:59:03 +00:00
jetstack-botandGitHub 969b678f33 Merge pull request #3647 from irbekrm/3644_removes_max_and_min_crd_fields
Fix Helm chart type conversion bug
v1.2.0
2021-02-10 15:59:36 +01:00
irbekrmandRichard Wall 959e581368 Removes implementation-specific comment from api
Co-authored-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-02-10 13:29:05 +00:00
irbekrmandJoshVanL 59f52139dc Finishes sentences with a full stop
Co-authored-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-02-10 09:43:34 +00:00
irbekrm 863c709a19 Removes minimum and maximum fields from Certificate CRD
This was done to fix Helm data type conversion problem- see issue #3644 for more context

Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-02-09 17:08:29 +00:00
jetstack-botandGitHub 35febb1717 Merge pull request #3505 from hugoboos/ocsp-server
Add option to specify OCSP server #3497
v1.2.0-alpha.2
2021-02-05 11:27:37 +00:00
jetstack-botandGitHub c932a7135d Merge pull request #3545 from meyskens/ingress-ku
Allow ingress-shim to specify key usages + add server-auth to default
2021-02-05 10:50:37 +00:00
Maël ValaisandJames Munnelly 95f8410194 remove the unit test, see reason in the commit message
The reason I had to withdraw from writing this unit test is that the
ca.CA type in pkg/issuer/ca does not implement the Sign function, which
means I cannot test the Sign feature.

I then tried to implement the same unit test to
pkg/controller/certificaterequests/ca, but the existing unit test do not
check the fields inside the produced certificate, which means I cannot
ensure that the ocspServers fields has properly been applied to the
certificate.

I will write a proper unit test... a bit later.

Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: James Munnelly <james@munnelly.eu>
2021-02-05 10:21:27 +01:00
Maël ValaisandJames Munnelly 11b9d71708 ca issuer: add a unit test with the ocsp servers field
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: James Munnelly <james@munnelly.eu>
2021-02-05 10:20:55 +01:00
joshvanl 15536801f0 Revert ingress key usage annotation to default the same as Certificate
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-02-04 16:08:30 +00:00
jetstack-botandGitHub 461a41046c Merge pull request #3628 from wallrj/3627-fix-crd-duplication
Fix duplication of the CRD definitions in cert-manager.yaml
2021-02-04 15:19:41 +00:00
Maartje Eyskensandjoshvanl 577c039220 Implement feedback
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2021-02-04 15:11:00 +00:00
Maartje Eyskensandjoshvanl bfce24fd59 Fix sync tests
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2021-02-04 15:11:00 +00:00
Maartje Eyskensandjoshvanl 8ec816814f update bazel
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2021-02-04 15:11:00 +00:00
Maartje Eyskensandjoshvanl bbb75ee52f Allow ingress-shim to specify key usages + add server-auth to default
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2021-02-04 15:11:00 +00:00
Richard Wall 0255304ef4 Fix the helm install --set installCRDs=true option
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-02-04 14:05:49 +00:00
jetstack-botandGitHub 4fe609156b Merge pull request #3538 from chulkilee/patch-1
Fix comments for docs on types_certificate.go
2021-02-03 15:09:11 +00:00
Richard Wall dd4219501d Fix duplication of the CRD definitions in cert-manager.yaml
* CRDs are already included by virtue of the manifests.helm target

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-02-03 11:50:19 +00:00
jetstack-botandGitHub b809b17a6f Merge pull request #3623 from irbekrm/2009_skip_invalid_ingress_tls_entries
Skips invalid Ingress tls entries instead of invalidating the Ingress
2021-02-03 10:23:10 +00:00
Maël ValaisandJames Munnelly ba22785445 Rename ocspServer to oscpServers
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: James Munnelly <james@munnelly.eu>
2021-02-03 11:13:32 +01:00
Maël Valais d5c485970d issuer's ocsp server: add an example URL to the API
Signed-off-by: Maël Valais <mael@vls.dev>
2021-02-03 09:42:34 +01:00
Maël Valais 9fb0876d21 issuer's ocsp server: add validation of the URL
Signed-off-by: Maël Valais <mael@vls.dev>
2021-02-03 09:42:01 +01:00
Hugo StijnsandMaël Valais 5f18cce622 add option to specify OCSP server
Signed-off-by: Hugo Stijns <hugo@boosboos.net>
Signed-off-by: Maël Valais <mael@vls.dev>
2021-02-03 09:09:03 +01:00
irbekrm be5ba022a9 Improves error checking in TestSync function
Also corrects some expected error values in test cases

Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-02-02 11:23:42 +00:00
irbekrm bb99260365 Skips an invalid Ingress.spec.tls entry instead of invalidating the whole Ingress
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-02-01 19:32:36 +00:00
Maartje EyskensandGitHub 33f1881190 Merge pull request #3532 from meyskens/recursive-cname
Make CNAME resolver recursive
v1.2.0-alpha.1
2021-01-27 16:28:40 +01:00
jetstack-botandGitHub 211230383e Merge pull request #3604 from irbekrm/3587-cli-context-handling
Passes a singe context with cancel func to all the kubectl plugin com…
2021-01-27 15:31:35 +01:00
jetstack-botandGitHub aad78b6141 Merge pull request #3583 from meyskens/crd-cat
Add CRD categories
2021-01-27 14:44:35 +01:00
irbekrm 34fd9e9fef Makes /cmd/cainjector/main more DRY
reuses util.ContextWithStopCh to create a context with cancel func

Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-01-27 13:32:23 +00:00
irbekrm 1abc7107ca Passes a single context with cancel func to all the kubectl plugin commands
Signed-off-by: irbekrm <irbekrm@gmail.com>

Don't duplicate the existing ContextWithStopCh function

Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-01-27 13:06:34 +00:00
jetstack-botandGitHub 26afeceb2b Merge pull request #3457 from meyskens/inspect-secret
Add `inspect secret` command
2021-01-22 16:19:03 +01:00