Files
David Bond 15381e4286 Make controller's sync period configurable
Fixes #3915

Adds the `sync-period` flag (defaulted to 1s), that allows modification of the frequency at which the controller will
pull items off the workqueue for processing.

```release-note
Adds --sync-period flag to modify the period of time between items being pulled from the controller's workqueue.
```

Signed-off-by: David Bond <davidsbond93@gmail.com>
2021-04-23 10:44:58 +01:00

172 lines
4.4 KiB
Go

/*
Copyright 2020 The cert-manager Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package controller
import (
"context"
"fmt"
"sync"
"time"
"k8s.io/apimachinery/pkg/util/wait"
"k8s.io/client-go/tools/cache"
"k8s.io/client-go/util/workqueue"
logf "github.com/jetstack/cert-manager/pkg/logs"
"github.com/jetstack/cert-manager/pkg/metrics"
)
type runFunc func(context.Context)
type runDurationFunc struct {
fn runFunc
duration time.Duration
}
type queueingController interface {
Register(*Context) (workqueue.RateLimitingInterface, []cache.InformerSynced, error)
ProcessItem(ctx context.Context, key string) error
}
func NewController(
ctx context.Context,
name string,
metrics *metrics.Metrics,
syncFunc func(ctx context.Context, key string) error,
mustSync []cache.InformerSynced,
runDurationFuncs []runDurationFunc,
queue workqueue.RateLimitingInterface,
syncPeriod time.Duration,
) Interface {
return &controller{
ctx: ctx,
name: name,
metrics: metrics,
syncHandler: syncFunc,
mustSync: mustSync,
runDurationFuncs: runDurationFuncs,
queue: queue,
syncPeriod: syncPeriod,
}
}
type controller struct {
// ctx is the root golang context for the controller
ctx context.Context
// name is the name for this controller
name string
// the function that should be called when an item is popped
// off the workqueue
syncHandler func(ctx context.Context, key string) error
// mustSync is a slice of informers that must have synced before
// this controller can start
mustSync []cache.InformerSynced
// a set of functions that will be called just after controller initialisation, once.
runFirstFuncs []runFunc
// a set of functions that should be called every duration.
runDurationFuncs []runDurationFunc
// queue is a reference to the queue used to enqueue resources
// to be processed
queue workqueue.RateLimitingInterface
// metrics is used to expose Prometheus, shared by all controllers
metrics *metrics.Metrics
// syncPeriod is used to configure the frequency that items are pulled from the workqueue.
syncPeriod time.Duration
}
// Run starts the controller loop
func (c *controller) Run(workers int, stopCh <-chan struct{}) error {
ctx, cancel := context.WithCancel(c.ctx)
defer cancel()
log := logf.FromContext(ctx)
log.V(logf.DebugLevel).Info("starting control loop")
// wait for all the informer caches we depend on are synced
if !cache.WaitForCacheSync(stopCh, c.mustSync...) {
return fmt.Errorf("error waiting for informer caches to sync")
}
var wg sync.WaitGroup
for i := 0; i < workers; i++ {
wg.Add(1)
go wait.Until(func() {
defer wg.Done()
c.worker(ctx)
}, c.syncPeriod, stopCh)
}
for _, f := range c.runFirstFuncs {
f(ctx)
}
for _, f := range c.runDurationFuncs {
go wait.Until(func() { f.fn(ctx) }, f.duration, stopCh)
}
<-stopCh
log.V(logf.InfoLevel).Info("shutting down queue as workqueue signaled shutdown")
c.queue.ShutDown()
log.V(logf.DebugLevel).Info("waiting for workers to exit...")
wg.Wait()
log.V(logf.DebugLevel).Info("workers exited")
return nil
}
func (c *controller) worker(ctx context.Context) {
log := logf.FromContext(c.ctx)
log.V(logf.DebugLevel).Info("starting worker")
for {
obj, shutdown := c.queue.Get()
if shutdown {
break
}
var key string
// use an inlined function so we can use defer
func() {
defer c.queue.Done(obj)
var ok bool
if key, ok = obj.(string); !ok {
return
}
log := log.WithValues("key", key)
log.V(logf.DebugLevel).Info("syncing item")
// Increase sync count for this controller
c.metrics.IncrementSyncCallCount(c.name)
if err := c.syncHandler(ctx, key); err != nil {
log.Error(err, "re-queuing item due to error processing")
c.queue.AddRateLimited(obj)
return
}
log.V(logf.DebugLevel).Info("finished processing work item")
c.queue.Forget(obj)
}()
}
log.V(logf.DebugLevel).Info("exiting worker loop")
}