chore: add changelog 4.3.4

.travis.yml

@@ -1,9 +1,3 @@
 sudo: false
-cache:
-  directories:
-    - $HOME/.yarn-cache
 language: node_js
 node_js: stable
-os:
-  - linux
-  - osx

CHANGELOG.md

@@ -1,3 +1,13 @@
+<a name="4.3.4"></a>
+## [4.3.4](https://github.com/QingWei-Li/docsify/compare/v4.3.3...v4.3.4) (2017-09-07)
+
+
+### Bug Fixes
+
+* scroll position issue, fixed [#234](https://github.com/QingWei-Li/docsify/issues/234) ([388ed3d](https://github.com/QingWei-Li/docsify/commit/388ed3d))
+
+
+
 <a name="4.3.3"></a>
 ## [4.3.3](https://github.com/QingWei-Li/docsify/compare/v4.3.2...v4.3.3) (2017-09-06)
 

docs/_coverpage.md

@@ -1,6 +1,6 @@
 ![logo](_media/icon.svg)
 
-# docsify <small>4.3.3</small>
+# docsify <small>4.3.4</small>
 
 > A magical documentation site generator.
 

lib/docsify.js

@@ -3130,6 +3130,7 @@ var nav = {};
 var hoverOver = false;
 var scroller = null;
 var enableScrollEvent = true;
+var coverHeight = 0;
 
 function scrollTo (el) {
   if (scroller) { scroller.stop(); }
@@ -3151,7 +3152,7 @@ function highlight () {
   var wrap = find(sidebar, '.sidebar-nav');
   var active = find(sidebar, 'li.active');
   var doc = document.documentElement;
-  var top = doc && doc.scrollTop || document.body.scrollTop;
+  var top = (doc && doc.scrollTop || document.body.scrollTop) - coverHeight;
   var last;
 
   for (var i = 0, len = anchors.length; i < len; i += 1) {
@@ -3195,7 +3196,8 @@ function highlight () {
 }
 
 function scrollActiveSidebar (router) {
-  if (isMobile) { return }
+  var cover = find('.cover.show');
+  coverHeight = cover ? cover.offsetHeight : 0;
 
   var sidebar = getNode('.sidebar');
   var lis = findAll(sidebar, 'li');
@@ -3213,6 +3215,8 @@ function scrollActiveSidebar (router) {
     if (href) { nav[decodeURIComponent(href)] = li; }
   }
 
+  if (isMobile) { return }
+
   off('scroll', highlight);
   on('scroll', highlight);
   on(sidebar, 'mouseover', function () { hoverOver = true; });
@@ -3946,7 +3950,7 @@ initGlobalAPI();
 /**
  * Version
  */
-Docsify.version = '4.3.3';
+Docsify.version = '4.3.4';
 
 /**
  * Run Docsify

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "docsify",
-  "version": "4.3.3",
+  "version": "4.3.4",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "docsify",
-  "version": "4.3.3",
+  "version": "4.3.4",
   "description": "A magical documentation generator.",
   "author": {
     "name": "qingwei-li",

packages/docsify-server-renderer/package-lock.json

@@ -37,5 +37,5 @@
       "integrity": "sha1-6DWIAbhrg7F1YNTjw4LXrvIQCUQ="
     }
   },
-  "version": "4.3.3"
+  "version": "4.3.4"
 }

packages/docsify-server-renderer/package.json

@@ -1,6 +1,6 @@
 {
   "name": "docsify-server-renderer",
-  "version": "4.3.3",
+  "version": "4.3.4",
   "description": "docsify server renderer",
   "author": {
     "name": "qingwei-li",

src/core/event/scroll.js

@@ -6,6 +6,7 @@ const nav = {}
 let hoverOver = false
 let scroller = null
 let enableScrollEvent = true
+let coverHeight = 0
 
 function scrollTo (el) {
   if (scroller) scroller.stop()
@@ -27,7 +28,7 @@ function highlight () {
   const wrap = dom.find(sidebar, '.sidebar-nav')
   let active = dom.find(sidebar, 'li.active')
   const doc = document.documentElement
-  const top = doc && doc.scrollTop || document.body.scrollTop
+  const top = (doc && doc.scrollTop || document.body.scrollTop) - coverHeight
   let last
 
   for (let i = 0, len = anchors.length; i < len; i += 1) {
@@ -71,7 +72,8 @@ function highlight () {
 }
 
 export function scrollActiveSidebar (router) {
-  if (isMobile) return
+  const cover = dom.find('.cover.show')
+  coverHeight = cover ? cover.offsetHeight : 0
 
   const sidebar = dom.getNode('.sidebar')
   const lis = dom.findAll(sidebar, 'li')
@@ -89,6 +91,8 @@ export function scrollActiveSidebar (router) {
     if (href) nav[decodeURIComponent(href)] = li
   }
 
+  if (isMobile) return
+
   dom.off('scroll', highlight)
   dom.on('scroll', highlight)
   dom.on(sidebar, 'mouseover', () => { hoverOver = true })