Improve approve MR widget

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
This commit is contained in:
Dmitriy Zaporozhets
2015-06-12 16:00:25 +02:00
parent 33dce2df6f
commit 07703c22b3
5 changed files with 10 additions and 22 deletions
@@ -188,11 +188,3 @@
.merge-request-form .select2-container {
width: 250px !important;
}
.approve-btn {
margin-right: 10px;
}
.approved-by-users {
padding: 5px 0;
}
@@ -29,3 +29,9 @@
Accepting this merge request will close #{@closes_issues.size == 1 ? 'issue' : 'issues'}
= succeed '.' do
!= gfm(issues_sentence(@closes_issues))
- if @merge_request.approvals.any?
.mr-widget-footer.approved-by-users
Approved by
- @merge_request.approved_by_users.each do |user|
= link_to_member(@project, user, name: false, size: 24)
@@ -24,12 +24,6 @@
%strong
= link_to "command line", "#modal_merge_info", class: "how_to_merge_link vlink", title: "How To Merge", "data-toggle" => "modal"
- if @merge_request.approvals.any?
.approved-by-users
Approved by
- @merge_request.approved_by_users.each do |user|
= link_to_member(@project, user, name: false, size: 24)
:coffeescript
disableButtonIfEmptyField '#commit_message', '.accept_merge_request'
@@ -1,13 +1,9 @@
%div
%h4
Requires #{pluralize(@merge_request.approvals_left, 'approval')}
%p Each merge request in this project must be approved by #{pluralize(@merge_request.approvals_required, 'user')} before it can be merged
- unless @merge_request.approved_by?(current_user)
.append-bottom-10
= form_for [:approve, @project.namespace.becomes(Namespace), @project, @merge_request], method: :post do |f|
= f.submit "Approve Merge Request", class: "btn btn-reopen approve-btn"
= f.submit "Approve Merge Request", class: "btn btn-primary approve-btn"
%p This merge request must be approved by #{pluralize(@merge_request.approvals_required, 'user')} before it can be merged
- if @merge_request.approvals.any?
.approved-by-users
Approved by
- @merge_request.approved_by_users.each do |user|
= link_to_member(@project, user, name: false, size: 24)
Binary file not shown.

Before

Width:  |  Height:  |  Size: 160 KiB

After

Width:  |  Height:  |  Size: 165 KiB