mirror of
https://github.com/wahyd4/gitlabhq.git
synced 2026-08-16 08:06:08 +10:00
Note strong_params
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
This commit is contained in:
@@ -21,7 +21,7 @@ class Projects::NotesController < Projects::ApplicationController
|
||||
end
|
||||
|
||||
def create
|
||||
@note = Notes::CreateService.new(project, current_user, params[:note]).execute
|
||||
@note = Notes::CreateService.new(project, current_user, note_params).execute
|
||||
|
||||
respond_to do |format|
|
||||
format.json { render_note_json(@note) }
|
||||
@@ -30,7 +30,7 @@ class Projects::NotesController < Projects::ApplicationController
|
||||
end
|
||||
|
||||
def update
|
||||
note.update_attributes(params[:note])
|
||||
note.update_attributes(note_params)
|
||||
note.reset_events_cache
|
||||
|
||||
respond_to do |format|
|
||||
@@ -109,4 +109,11 @@ class Projects::NotesController < Projects::ApplicationController
|
||||
def authorize_admin_note!
|
||||
return access_denied! unless can?(current_user, :admin_note, note)
|
||||
end
|
||||
|
||||
def note_params
|
||||
params.require(:note).permit(
|
||||
:note, :noteable, :noteable_id, :noteable_type, :project_id,
|
||||
:attachment, :line_code, :commit_id
|
||||
)
|
||||
end
|
||||
end
|
||||
|
||||
@@ -25,8 +25,6 @@ class Note < ActiveRecord::Base
|
||||
|
||||
default_value_for :system, false
|
||||
|
||||
#attr_accessible :note, :noteable, :noteable_id, :noteable_type, :project_id,
|
||||
#:attachment, :line_code, :commit_id
|
||||
attr_mentionable :note
|
||||
|
||||
belongs_to :project
|
||||
|
||||
Reference in New Issue
Block a user