Merge branch 'rs-show-owner-label' into 'master'

Allow `ProjectTeam#human_max_access` to return "Owner"



See merge request !2881
This commit is contained in:
Douwe Maan
2016-02-19 16:29:31 +01:00
committed by Rémy Coutable
parent 6eacfa9986
commit 554d9bf606
2 changed files with 18 additions and 8 deletions
+1 -1
View File
@@ -136,7 +136,7 @@ class ProjectTeam
end
def human_max_access(user_id)
Gitlab::Access.options.key max_member_access(user_id)
Gitlab::Access.options_with_owner.key(max_member_access(user_id))
end
# This method assumes project and group members are eager loaded for optimal
+17 -7
View File
@@ -68,14 +68,24 @@ describe ProjectTeam, models: true do
end
describe "#human_max_access" do
it "return master role" do
user = create :user
group = create :group
group.add_users([user.id], GroupMember::MASTER)
project = create(:project, namespace: group)
project.team << [user, :guest]
it 'returns Master role' do
user = create(:user)
group = create(:group)
group.add_master(user)
expect(project.team.human_max_access(user.id)).to eq("Master")
project = build_stubbed(:empty_project, namespace: group)
expect(project.team.human_max_access(user.id)).to eq 'Master'
end
it 'returns Owner role' do
user = create(:user)
group = create(:group)
group.add_owner(user)
project = build_stubbed(:empty_project, namespace: group)
expect(project.team.human_max_access(user.id)).to eq 'Owner'
end
end
end