home/gitlabhq
2
0
Fork 0
mirror of https://github.com/wahyd4/gitlabhq.git synced 2026-08-11 13:46:11 +10:00
Code Issues Packages Projects Releases Wiki Activity

Protect IssueObserver#send_reassigned_email method.

Browse Source
This commit is contained in:
Robb Kidd
2012-06-20 21:23:05 -04:00
parent 70c6b48ebc
commit 65989141dc
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/models/issue_observer.rb
+2
View File
@@ -11,6 +11,8 @@ class IssueObserver < ActiveRecord::Observer
Note.create_status_change_note(issue, current_user, 'reopened') if issue.is_being_reopened?
end
protected
def send_reassigned_email(issue)
recipient_ids = [issue.assignee_id, issue.assignee_id_was].keep_if {|id| id != current_user.id }
spec/models/issue_observer_spec.rb
+3 -3
View File
@@ -121,7 +121,7 @@ describe IssueObserver do
it_sends_a_reassigned_email_to assignee.id
it_sends_a_reassigned_email_to previous_assignee.id
subject.send_reassigned_email(issue)
subject.send(:send_reassigned_email, issue)
end
context 'does not send an email to the user who made the reassignment' do
@@ -130,14 +130,14 @@ describe IssueObserver do
it_sends_a_reassigned_email_to previous_assignee.id
it_does_not_send_a_reassigned_email_to assignee.id
subject.send_reassigned_email(issue)
subject.send(:send_reassigned_email, issue)
end
it 'if the user is the previous assignee' do
subject.stub(:current_user).and_return(previous_assignee)
it_sends_a_reassigned_email_to assignee.id
it_does_not_send_a_reassigned_email_to previous_assignee.id
subject.send_reassigned_email(issue)
subject.send(:send_reassigned_email, issue)
end
end
end