feature and fix for 500 on group missing

This commit is contained in:
James Lopez
2016-01-26 12:16:47 +01:00
parent eb7f669073
commit 89aeed183c
3 changed files with 10 additions and 0 deletions
+1
View File
@@ -81,6 +81,7 @@ class GroupsController < Groups::ApplicationController
def group
@group ||= Group.find_by(path: params[:id])
render_404 unless @group
end
def load_projects
+5
View File
@@ -3,6 +3,11 @@ Feature: Explore Groups
Background:
Given group "TestGroup" has private project "Enterprise"
Scenario: I should not see a group if it does not exist
When I sign in as a user
And I visit group "NonExistentGroup" page
Then page status code should be 404
Scenario: I should see group with private and internal projects as user
Given group "TestGroup" has internal project "Internal"
When I sign in as a user
+4
View File
@@ -26,6 +26,10 @@ class Spinach::Features::ExploreGroups < Spinach::FeatureSteps
visit group_path(Group.find_by(name: "TestGroup"))
end
step 'I visit group "NonExistentGroup" page' do
visit group_path(-1)
end
step 'I visit group "TestGroup" issues page' do
visit issues_group_path(Group.find_by(name: "TestGroup"))
end