home/gitlabhq
2
0
Fork 0
mirror of https://github.com/wahyd4/gitlabhq.git synced 2026-08-10 13:16:09 +10:00
Code Issues Packages Projects Releases Wiki Activity

Improve Milestones API specs

Browse Source 
Signed-off-by: Rémy Coutable <remy@rymai.me>
This commit is contained in:
Rémy Coutable
2016-04-25 18:07:51 +02:00
parent 03ae2cdbff
commit 97bd349146
2 changed files with 23 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG
-2
View File
@@ -8,8 +8,6 @@ v 8.7.1 (unreleased)
- Fix license detection to detect all license files, not only known licenses. !3878
- Use the `can?` helper instead of `current_user.can?`. !3882
- Prevent users from deleting Webhooks via API they do not own
- Use the `can?` helper instead of `current_user.can?`
- Filter confidential issues from milestones API if user does not have access
v 8.7.0
- Gitlab::GitAccess and Gitlab::GitAccessWiki are now instrumented
spec/requests/api/milestones_spec.rb
+23 -32
View File
@@ -140,43 +140,34 @@ describe API::API, api: true do
get api("/projects/#{project.id}/milestones/#{milestone.id}/issues")
expect(response.status).to eq(401)
end
end
describe 'confidential issues' do
it 'should return confidential issues to team members' do
public_project = create(:project, :public)
user = create(:user)
milestone = create(:milestone, project: public_project)
issue = create(:issue, project: public_project)
confidential_issue = create(:issue, confidential: true, project: public_project)
public_project.team << [user, :developer]
milestone.issues << issue
milestone.issues << confidential_issue
describe 'confidential issues' do
let(:public_project) { create(:project, :public) }
let(:milestone) { create(:milestone, project: public_project) }
let(:issue) { create(:issue, project: public_project) }
let(:confidential_issue) { create(:issue, confidential: true, project: public_project) }
before do
public_project.team << [user, :developer]
milestone.issues << issue << confidential_issue
end
get api("/projects/#{public_project.id}/milestones/#{milestone.id}/issues", user)
it 'returns confidential issues to team members' do
get api("/projects/#{public_project.id}/milestones/#{milestone.id}/issues", user)
expect(response.status).to eq(200)
expect(json_response).to be_an Array
expect(json_response.size).to eq(2)
expect(json_response.map { |issue| issue['id'] }).to include(issue.id, confidential_issue.id)
end
expect(response.status).to eq(200)
expect(json_response).to be_an Array
expect(json_response.size).to eq(2)
expect(json_response.map { |issue| issue['id'] }).to include(issue.id, confidential_issue.id)
end
it 'should not return confidential issues to regular users' do
public_project = create(:project, :public)
normal_user = create(:user)
milestone = create(:milestone, project: public_project)
issue = create(:issue, project: public_project)
confidential_issue = create(:issue, confidential: true, project: public_project)
public_project.team << [user, :developer]
milestone.issues << issue
milestone.issues << confidential_issue
it 'does not return confidential issues to regular users' do
get api("/projects/#{public_project.id}/milestones/#{milestone.id}/issues", create(:user))
get api("/projects/#{public_project.id}/milestones/#{milestone.id}/issues", normal_user)
expect(response.status).to eq(200)
expect(json_response).to be_an Array
expect(json_response.size).to eq(1)
expect(json_response.map { |issue| issue['id'] }).to include(issue.id)
expect(response.status).to eq(200)
expect(json_response).to be_an Array
expect(json_response.size).to eq(1)
expect(json_response.map { |issue| issue['id'] }).to include(issue.id)
end
end
end
end