home/gitlabhq
2
0
Fork 0
mirror of https://github.com/wahyd4/gitlabhq.git synced 2026-08-17 00:26:07 +10:00
Code Issues Packages Projects Releases Wiki Activity

Add note for short circuit eval when building builds

Browse Source
This commit is contained in:
Grzegorz Bizon
2016-06-15 10:11:09 +02:00
parent bf990fcda4
commit a76cbe5292
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/models/ci/pipeline.rb
+12 -2
View File
@@ -93,6 +93,11 @@ module Ci
def build_builds(user, trigger_request = nil, status = 'success')
return unless config_processor
##
# Note that `Array#any?` implements a short circuit evaluation, so we
# build builds only for the first stage that has builds available.
#
config_processor.stages.any? do |stage|
build_builds_for_stage(stage, user, status, trigger_request).present?
end
@@ -117,9 +122,14 @@ module Ci
prior_builds = latest_builds.where.not(stage: next_stages)
prior_status = prior_builds.status
# create builds for next stages based
##
# Create builds for next stages based.
#
# Note that there is a short circult evaluation here.
#
have_builds = next_stages.any? do |stage|
build_builds_for_stage(stage, build.user, prior_status, build.trigger_request).present?
build_builds_for_stage(stage, build.user, prior_status,
build.trigger_request).present?
end
save! if have_builds