Merge branch 'rs-default-clone-fixes' into 'master'

Simplify shared User SSH key steps

See merge request !2043

CHANGELOG

@@ -26,6 +26,7 @@ v 8.3.0 (unreleased)
   - Add languages page to graphs
   - Block LDAP user when they are no longer found in the LDAP server
   - Improve wording on project visibility levels (Zeger-Jan van de Weg)
+  - Automatically select default clone protocol based on user preferences (Eirik Lygre)
 
 v 8.2.3
   - Fix application settings cache not expiring after changes (Stan Hu)

features/steps/shared/user.rb

@@ -20,10 +20,10 @@ module SharedUser
   end
 
   step 'I have an ssh key' do
-    create(:key, user: @user, title: "An ssh-key", key: "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC+L3TbFegm3k8QjejSwemk4HhlRh+DuN679Pc5ckqE/MPhVtE/+kZQDYCTB284GiT2aIoGzmZ8ee9TkaoejAsBwlA+Wz2Q3vhz65X6sMgalRwpdJx8kSEUYV8ZPV3MZvPo8KdNg993o4jL6G36GDW4BPIyO6FPZhfsawdf6liVD0Xo5kibIK7B9VoE178cdLQtLpS2YolRwf5yy6XR6hbbBGQR+6xrGOdP16eGZDb1CE2bMvvJijjloFqPscGktWOqW+nfh5txwFfBzlfARDTBsS8WZtg3Yoj1kn33kPsWRlgHfNutFRAIynDuDdQzQq8tTtVwm+Yi75RfcPHW8y3P Work")
+    create(:personal_key, user: @user)
   end
 
   step 'I have no ssh keys' do
-    Key.delete_all
+    @user.keys.delete_all
   end
 end