home/gitlabhq
2
0
Fork 0
mirror of https://github.com/wahyd4/gitlabhq.git synced 2026-08-13 22:59:19 +10:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8534 from jvanbaarsen/fix-wonky-tests

Browse Source 
make sure the user.name is escaped
This commit is contained in:
Dmitriy Zaporozhets
2015-01-05 21:10:23 +02:00
parent 5dbbec4612 2a4ee2fd7f
commit dbdccd5d03
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spec/features/atom/users_spec.rb
+7 -2
View File
@@ -24,11 +24,12 @@ describe "User Feed", feature: true do
end
it "should have issue opened event" do
body.should have_content("#{user.name} opened issue ##{issue.iid}")
expect(body).to have_content("#{safe_name} opened issue ##{issue.iid}")
end
it "should have issue comment event" do
body.should have_content("#{user.name} commented on issue ##{issue.iid}")
expect(body).
to have_content("#{safe_name} commented on issue ##{issue.iid}")
end
end
end
@@ -40,4 +41,8 @@ describe "User Feed", feature: true do
def note_event(note, user)
EventCreateService.new.leave_note(note, user)
end
def safe_name
html_escape(user.name)
end
end