Prefer string for describe, feedback from:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12321029
This commit is contained in:
Lin Jen-Shin
2016-06-09 16:00:24 +08:00
parent 9e14ebe6bc
commit de04004803
+5 -5
View File
@@ -36,7 +36,7 @@ describe Ci::Runner, models: true do
end
end
describe :assign_to do
describe '#assign_to' do
let!(:project) { FactoryGirl.create :empty_project }
let!(:shared_runner) { FactoryGirl.create(:ci_runner, :shared) }
@@ -49,7 +49,7 @@ describe Ci::Runner, models: true do
it { expect(shared_runner.only_for?(project)).to be_truthy }
end
describe :online do
describe '.online' do
subject { Ci::Runner.online }
before do
@@ -60,7 +60,7 @@ describe Ci::Runner, models: true do
it { is_expected.to eq([@runner2])}
end
describe :online? do
describe '#online?' do
let(:runner) { FactoryGirl.create(:ci_runner, :shared) }
subject { runner.online? }
@@ -90,7 +90,7 @@ describe Ci::Runner, models: true do
end
end
describe :status do
describe '#status' do
let(:runner) { FactoryGirl.create(:ci_runner, :shared, contacted_at: 1.second.ago) }
subject { runner.status }
@@ -128,7 +128,7 @@ describe Ci::Runner, models: true do
end
end
describe :specific_for do
describe '.specific_for' do
let(:runner) { create(:ci_runner) }
let(:project) { create(:project) }
let(:another_project) { create(:project) }