home/gitlabhq
2
0
Fork 0
mirror of https://github.com/wahyd4/gitlabhq.git synced 2026-08-17 08:36:06 +10:00
Code Issues Packages Projects Releases Wiki Activity

Fix user API tests succeeding for the wrong reason

Browse Source 
The requests were missing multiple required attributes, while testing for single attribute missing.
Added test for checking username as required attribute.
This commit is contained in:
Boyan Tabakov
2015-04-22 08:03:38 +03:00
parent 5640445108
commit e5b32f3c20
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spec/requests/api/users_spec.rb
+9 -4
View File
@@ -110,17 +110,22 @@ describe API::API, api: true do
end
it 'should return 400 error if name not given' do
post api('/users', admin), email: 'test@example.com', password: 'pass1234'
post api('/users', admin), attributes_for(:user).except(:name)
expect(response.status).to eq(400)
end
it 'should return 400 error if password not given' do
post api('/users', admin), email: 'test@example.com', name: 'test'
post api('/users', admin), attributes_for(:user).except(:password)
expect(response.status).to eq(400)
end
it "should return 400 error if email not given" do
post api('/users', admin), password: 'pass1234', name: 'test'
it 'should return 400 error if email not given' do
post api('/users', admin), attributes_for(:user).except(:email)
expect(response.status).to eq(400)
end
it 'should return 400 error if username not given' do
post api('/users', admin), attributes_for(:user).except(:username)
expect(response.status).to eq(400)
end