home/gitlabhq
2
0
Fork 0
mirror of https://github.com/wahyd4/gitlabhq.git synced 2026-08-17 00:26:07 +10:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'fix/group-visibility-ui-in-app-settings' into 'master'

Browse Source 
Fix group visibility form layout in application settings

## What does this MR do?

This fixes UI consistency related to setting group visibility levels in application settings. See screenshots.

## Screenshots (if relevant)

#### Before

![visiblity_consistency](/uploads/9cf9b517e25cd661ac61bdd7ca2d82f4/visiblity_consistency.png)

#### After

![group_visibility_after](/uploads/7b317684d047716f2aa5e60d19a4281b/group_visibility_after.png)

See merge request !4848
This commit is contained in:
Jacob Schatz
2016-06-28 20:29:39 +00:00
parent bcebdee751 7dc45236d9
commit ebe21acc2a
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG
+2
View File
@@ -72,6 +72,8 @@ v 8.9.1
- Remove duplicate 'New Page' button on edit wiki page
v 8.9.0
v 8.9.0 (unreleased)
- Fix group visibility form layout in application settings
- Fix builds API response not including commit data
- Fix error when CI job variables key specified but not defined
- Fix pipeline status when there are no builds in pipeline
app/views/admin/application_settings/_form.html.haml
+1 -1
View File
@@ -15,7 +15,7 @@
= f.label :default_snippet_visibility, class: 'control-label col-sm-2'
.col-sm-10
= render('shared/visibility_radios', model_method: :default_snippet_visibility, form: f, selected_level: @application_setting.default_snippet_visibility, form_model: ProjectSnippet.new)
.form-group.group-visibility-level-holder
.form-group.project-visibility-level-holder
= f.label :default_group_visibility, class: 'control-label col-sm-2'
.col-sm-10
= render('shared/visibility_radios', model_method: :default_group_visibility, form: f, selected_level: @application_setting.default_group_visibility, form_model: Group.new)