Add Issue/PR Templates to deter issues/contributions on the GitHub mirror of the project
## What does this MR do?
Adds GitHub-specific `ISSUE_TEMPLATE.md` and `PULL_REQUEST_TEMPLATE.md` files in a `.github` directory. To prevent new issues/PRs, I figured it'd be good to direct users/contributors to open issues/contribute code in the "correct" project.
## Are there points in the code the reviewer needs to double check?
Wording/phrasing, mostly.
## Why was this MR needed?
The GitHub issue tracker is being closed, and PRs on GitHub haven't been accepted for a while now. This was discussed briefly during the GitLab Strategy Session at the Austin Summit.
cc: @dzaporozhets @rymai @MrChrisW @dblessing @virtuacreative @amara
See merge request !4324
Enable RuboCop for migrations
## What does this MR do?
Enable RuboCop for all files inside `db/migrate`, then add magic comments to all existing files, so that this only affects new migrations.
## Are there points in the code the reviewer needs to double check?
This entire change is a config change and a bunch of comments.
## Why was this MR needed?
```
Yorick Peterse [11:55 AM]
I don't think we have any use case for nested def, might as well blacklist it
Sean McGivern [11:57 AM]
http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/NestedMethodDefinition
Sean McGivern [11:57 AM]
hmm, it's already enabled
Sean McGivern [11:57 AM]
... because we exclude `db/` from rubocop 🙂
Douwe Maan [11:57 AM]
@smcgivern: heh
Sean McGivern [11:59 AM]
I guess that's because we don't want to change the old migrations? I wonder if it's worth enabling it and adding magic comments to all the previous ones to ignore rubocop
Douwe Maan [11:59 AM]
@smcgivern: agreed
```
## What are the relevant issue numbers?
None.
## Screenshots (if relevant)
None, but if I remove the magic comment from the migration `20160416182152_convert_award_note_to_emoji_award.rb` I get:
```
$ be rubocop
Inspecting 1959 files
..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
db/migrate/20160416182152_convert_award_note_to_emoji_award.rb:3:5: W: Lint/NestedMethodDefinition: Method definitions must not be nested. Use lambda instead.
def up ...
^^^^^^
1959 files inspected, 1 offense detected
```
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !4559
Wrap all rate limiting logic inside GitHub API client
## What does this MR do?
Move the actual rate limiting logic to GitHub API to clean the code inside the GitHub importer, and avoid code duplication.
## Are there points in the code the reviewer needs to double check?
No there aren't.
## Why was this MR needed?
Avoid code duplication to handle API rate limit in every call to the GitHub API.
## What are the relevant issue numbers?
There are none.
## Screenshots (if relevant)
Not relevant.
See merge request !4552
Properly quote table name in Rake task for MySQL and PostgreSQL compatibility
!4318 broke the gitlab:db:drop_tables functionality for PostgreSQL.
Closes#15259
See merge request !4577
Add milestone expire date to the right sidebar
## What does this MR do?
Shows milestone expire date tooltip in the sidebar. It also shows the tooltip when sidebar is collapsed.
## Are there points in the code the reviewer needs to double check?
`common_utils.js.coffee` and `milestones_helper.rb` should be reviewed deeply.
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/17355
## Screencast
See merge request !4448
Checks for undefined when inserting autocomplete into textarea
## What does this MR do?
Correctly checks for undefined before inserting anything into the textarea when using autocomplete. This happens because the loading indicator tries to insert `@undefined` which we dont want to insert.
See merge request !4561
Fix bug with SQL syntax error during backup restoration
## What does this MR do?
It properly escapes the table name in the `DROP TABLE IF EXISTS ...` statement used during restore of a backup.
## Are there points in the code the reviewer needs to double check?
Please check compatibility with PostgreSQL
## Why was this MR needed?
Fix an issue with backups can not be restored if MySQL is used as database for GitLab.
## What are the relevant issue numbers?
#15259
## Screenshots (if relevant)
-
See merge request !4318
Fix empty user projects snippets list
## What are the relevant issue numbers?
Closes#17952#17816 and #17737
cc: @lbennett @jschatz1
See merge request !4532
Improve ui consistency. Part 2
* Use responsive top-area on project branches and tags pages
* Use default button size in the content list controls
* Improve button margin for btn-grouped css class
For https://gitlab.com/gitlab-org/gitlab-ce/issues/18324
See merge request !4536
Improved the UX of issue & milestone date picker
## What does this MR do?
Improves the UX of the date picker on issue form & milestone form.
## What are the relevant issue numbers?
Closes#18198
## Screenshots (if relevant)
### Issues
### Project milestones
### Group milestones
See merge request !4485
Only load Chart.js when necessary.
Only load Chart.js where it's used, namely the Graphs section. Follow up on !4394.
cc: @jschatz1
See merge request !4516
Fix local timeago on user dashboard
## What does this MR do?
Fixes incorrect date times on tooltips on the dashboard page
## Are there points in the code the reviewer needs to double check?
Yes, The tooltip has to be recreated again because we needed a custom CSS classname in order to fix the date being splitted into two lines.
## Why was this MR needed?
Because the datetimes were incorrect we have to have the same format for .timeago() instances.
## What are the relevant issue numbers?
#17607
## Screenshots (if relevant)
**Before**
<img src="/uploads/f40cd58e8086d9675262e98a1fe57885/Screen_Shot_2016-05-24_at_7.23.25_PM.png" width="705">
**After**
<img src="/uploads/bd48046ef11659cc742f827b3404fbcd/Screen_Shot_2016-05-24_at_7.22.29_PM.png" width="704">
See merge request !4285
Improve input padding, fix#18237.
## What does this MR do?
Improves horizontal padding for input fields.
## What are the relevant issue numbers?
#18237
## Screenshots (if relevant)
Before:
After:
cc: @jschatz1
See merge request !4489
Use warning color merge conflicts icon in MR status widget.
Fixes#18174
### Before
### After
See merge request !4487
Edit form background color on highlighted note
## What does this MR do?
Added white background to edit form when in a highlighted note
## What are the relevant issue numbers?
Closes#18101
## Screenshots (if relevant)
See merge request !4435
Toggling a task in a description with mentions doesn't creates a Todo
When user toggle a task list item in a description with a mention it
does not create an unnecessary Todo for that mention.
Closes#14116
See merge request !4568
Blur button tags when pressed to remove the focus state.
## Before
## After
See merge request !4418
Updated labels UI
- Fixed alignment issues
- Added dropdown to mobile to make the options look nicer & to save space
Closes#14227
See merge request !4273
#17562 Fixes issues list filter only visible when user is logged in
## What does this MR do?
1. Moves the issue/MR list search form out of the `if current_user` conditional, allowing guests to view the field.
2. Adds some margin to the search form, this is because in mobile view for guest users, the field was not supported by the RSS button and the New Issue button and would drop to meet the list.
## Are there points in the code the reviewer needs to double check?
Are there any views where the `margin-bottom: 12px` will affect the styling?
## Why was this MR needed?
Guest user UX. Nothing feels better than increasing intangible value!
## What are the relevant issue numbers?
Fixes#17562.
## Screenshots (if relevant)
/cc @jschatz1
**UPDATE:**
See merge request !4171
Fix 2FA-based login for LDAP users
The OTP input form is shared by both LDAP and standard logins, but when
coming from an LDAP-based form, the form parameters aren't nested in a
Hash based on the `resource_name` value.
Now we check for a nested `remember_me` parameter and use that if it
exists, or fall back to the non-nested parameters if it doesn't.
Somewhat confusingly, the OTP input form _does_ nest parameters under
the `resource_name`, regardless of what type of login we're coming from,
so that allows everything else to work as normal.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/18185
See merge request !4493
This adds templates for Issues/Pull Requests in a `.github` directory. These only effect issues/PRs opened in the GitHub mirror of the GitLab project. As we're shutting these down, I thought it'd be good to direct users/contributors to open issues/contribute code in the "correct" project.
Jacob Vosmaer
Rémy Coutable
Douwe Maan
Timothy Andrew
Jacob Schatz
Fatih Acet
Robert Speicher
Robert Speicher
Stan Hu
Phil HughesandJacob Schatz
Alfredo Sumaran
Douglas Barbosa Alexandre
Connor Shea