Fix visibility level texts on application settings
Introduced by me through !2005
Before:
After:
See merge request !2611
Save button on app settings now btn-save
Some save buttons where `btn-primary` where throughout the application these usually are `btn-save`.
Before (Application settings)
After
See merge request !2612
Track project import failure
Fixes#12512
This also help us on identify why the import process is returning the wrong status when the project was successfully imported. Like mentioned in the issue #12450
See merge request !2538
Add tests for clicking a row in build artifacts browser
This adds a feature tests for clicking a row, which is handled by javascript event.
/cc @ayufan
See merge request !2551
Make the `/groups` route behave as expected
The route is supposed to redirect the Groups#index request based on
whether or not a user was logged in. If they are, we redirect them to
their groups dashboard; if they're not, we redirect them to the public
Explore page.
But due to overly aggressive `before_action`s that weren't excluding (or including) the
`index` action, the request always resulted in a 404, whether a user was
logged in or not.
Closes#12660
See merge request !2580
Highlight note code and edit preview
More highlighting fixes! Highlighting wasn't applied all the way for
code in notes, diff notes diffs and diff preview (on the file edit page).
The CSS changes further unify the styling for file-content highlighting,
diff highlighting and note code highlighting.
See merge request !2594
Refactor JIRA documentation
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/12680
## TODO
- [x] Move JIRA docs from `integration/` to `project_services/`
- [x] Split old JIRA info
- [x] Add note on document migration
- [x] Change references to new location
- [x] Add new images
- [x] Clean-up `jira.md`
See merge request !2592
Substituted deprecated forum link with project issues link.
Within the promo partial template we had a Requests link to the
deprecated Forum which is now directing to the project's Issue page.
See merge request !2255
This ensures that an instrumented method that doesn't take arguments
reports an arity of 0, instead of -1.
If Ruby had a proper method for finding out the required arguments of a
method (e.g. Method#required_arguments) this would not have been an
issue. Sadly the only two methods we have are Method#parameters and
Method#arity, and both are equally painful to use.
Fixesgitlab-org/gitlab-ce#12450
Adds base64 background search icon.
All inputs of type `search` will have the gray background
and search icon centered.
Because the search magnifier is a bg image,
I had to hide it with `[value=""]`.
I added a little javascript to make sure each input always has it's
own `value`.
A text and icon placeholder in the center of the input that disappears when typed is only possible with javascript. If you just want the icon or just the text it can be done with css alone.
If you want the icon/text justified left, then the search magnifier does not have to disappear.
Fixes#11870
cc @skyruler @creamzy
See merge request !2546
Zeger-Jan van de Weg
Douwe Maan
Douglas Barbosa Alexandre
Stan Hu
Robert Speicher
Robert Speicher
Achilleas Pipinellis
Sytse Sijbrandij
Yorick Peterse
Jose Torres
Jacob Schatz
Marcin Zajączkowski
Valery Sizov
Douwe Maan
Kamil Trzciński
Jacob Schatz