Rails adds an empty error to the Errors object even if you just call
`#[]` on it:
```
[1] pry(main)> u = User.last
[2] pry(main)> u.errors.keys
=> []
[3] pry(main)> u.errors[:username].present?
=> false
[4] pry(main)> u.errors.keys
=> [:username]
```
Fixes padding loss after editing a diff comment
Also applies .timeago() to comment datetimes when diff page is entered directly.
Also fixes the vertical position of the comment count icon.
See merge request !3012
Fix for project paths ending in .wiki
This prevents `Git operation was rejected by pre-receive hook` when
an actual project ending with .wiki is thought to be a wiki by the
`Internal` API.
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/13742
See merge request !2960
Improve implementation to check read access to forks and add pagination.
Fixes#13648
The following optimizations where made:
- Pagination was added.
- Code to check for read permissions to forks was optimized, in the past we were doing too many queries for each project.
See merge request !2991
Removed NGProgress
In an effort to get the JS file size down, i've removed NGProgress and replaced with TurboLinks own loading indicator
Ref #13820
See merge request !3004
Changed too many changes buttons to white
Closes#13751
See merge request !3002
Small css cleanup for todos feature
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Cleanup for !2817Fixes#13816
cc @jschatz1 @skyruler @dbalexandre
See merge request !2996
Branded appearance to CE
Closes#11489
The difference with the EE version is only that there is no distinction between light and dark logos, though this wasn't used anyway. If this is fine, I'll create a MR on EE too.
TODO:
- [x] Copy docs
- [x] Make new screenshots
- [ ] Remove Custom Welcome message feature?
@rymai: I was unsure what labels to add to ping you, so I just ping you like this 😉
/cc @DouweM
See merge request !2927
Adjust documentation of permissions
## What does this MR do?
This MR improves the documentation of the permissions by mentioning that internal projects do not enforce the Guest role.
## Are there points in the code the reviewer needs to double check?
No code was touched - only the documentation was adjusted.
## Why was this MR needed?
Without this adjustment it might not be clear how you can set up an internal project to be pullable by everyone whilst having the issue tracker and labels managed by permitted people only.
## What are the relevant issue numbers?
#13679
See merge request !2925
Strip leading and trailing spaces in URL validator
_Originally opened at !2914 by @evuez._
It makes URLs in webhooks valid even if they contain leading and/or trailing spaces.
Spaces are hard to notice in input fields, this helps users by accepting leading and trailing spaces in webhooks URLs.
Fixes#13652
See merge request !2939
Created helper class to hide content in issue sidebar when collapsed
Closes#13764
See merge request !2968
Refactor html/css for lists and improve help UI page
* dry lists html/css removing a lot of style duplicates
* fix snippets list to match common style
* fix extra bottom margin for groups list
* improve help page ui so it looks clean
Fixes#11873
See merge request !2977
Robert Speicher
Jacob Schatz
Dmitriy Zaporozhets
Robert Speicher
Alfredo Sumaran
Douwe Maan
Achilleas Pipinellis
James Lopez
Phil Hughes
Thomas Schmidt
Rubén Dávila
evuezandRobert Speicher
Rémy Coutable
Kamil Trzciński