Prevents floated button group on issues view
Issue #13359
See merge request !2826
fix table in doc/ci/variables/README.md
The table was missing a column separator, causing GitLab to render the
markdown incorrectly.
[ci skip]
See merge request !2840
Sidebar fixes
Fixes#13215
* when editing a dropdown, but not changing anything you end up in an ugly state
* the hover-over state for the subscribe and other buttons are veeery subtle
* the collapse button needs some sort of hover-over state
* the reference gets shortened. It always got shortened. Not an issue with this in particular.
* the minimized sidebar is not functional. The copy button doesn't do anything
* looks all funky in safari (not for me)
See merge request !2736
Fix the "x of y" displayed at the top of Issuables' sidebar
1. We now display the index of the current issuable among all its project's
issuables, of the same type and with the same state.
1. Also, refactored a bit the Issuable helpers into a new `IssuablesHelper`
module.
1. Added acceptance specs for the sidebar counter.
Note: I didn't add a CHANGELOG item since it's a bug fix for an unreleased version.
Fixes#13356.
See merge request !2818
Eager-load image blob data in diffs
Since gitlab_git 8.0, blob data are lazy-loaded so we have to call
`blob.load_all_data!(repo)` to eager-load them.
Fixes#13458.
/cc @jacobvosmaer @dblessing @rspeicher
### New image in commit view
#### Before
#### After
### Replaced image in commit view
#### Before
#### After
### Deleted image in commit view
#### Before
#### After
### Image diff in merge request diff view
#### Before
#### After
See merge request !2830
1. We now display the index of the current issuable among all its project's
issuables, of the same type and with the same state.
2. Also, refactored a bit the Issuable helpers into a new IssuablesHelper
module.
3. Added acceptance specs for the sidebar counter.
Fix duplicate "me" in tooltip of the "thumbsup" awards Emoji
Steps to reproduce:
1. Go to a MR or issue
2. Click on "thumbsup" Emoji 3 times
3. Observe the tooltip becomes "me, me"
Closes#13374, #12788
See merge request !2804
Fix relative links in other markup formats
_Originally opened at !1845 by @ben.boeckel._
- - -
The RelativeLinkFilter was not applied to other document formats, e.g.,
reStructuredText, so links from the Files view or the Project view did
not work.
Fixes#3533.
See merge request !2798
Fix duplicated branch creation/deletion Web hooks/service notifications when using Web UI
Similar to 423d2d6, except duplicates occurred only if a Web service (e.g. Slack) were
configured.
When deleting a branch, this is what was happening:
1. DeleteBranchService calls execute_hooks and execute_services
2. The call to repository.rm_branch triggers the GitHooksService.
3. This, in turn, calls GitPushService and then calls the same hooks/services again.
5145706 now makes it no longer necessary for DeleteBranchService and CreateBranchService to execute
the branch hooks/services. Note that tags behave differently in GitTagPushService and GitPushService
is not called.
Closes#10330
See merge request !2763
Don't try to mark broken MR as mergable
In case merge request is broken, we shouldn't check if the sha
is mergable, as it will be null, and there's no point, as we know
that it's not mergable.
See merge request !2783
Jacob Schatz
Jacob Schatz
Yorick Peterse
Douwe Maan
Robert Speicher
Richard Hansen
Achilleas Pipinellis
Alfredo Sumaran
Valery Sizov
Rémy Coutable
James Lopez
Sytse Sijbrandij
Robert Speicher
Stan Hu
Takuya Noguchi