Robert Speicher
bba7e786a6
Merge branch 'events-performance' into 'master'
...
Improve performance of retrieving last update times for events
See 75195eefcca4cb3961986c90c8e837da02f30134 and
https://gitlab.com/gitlab-org/gitlab-ce/issues/12415#note_3387317
for the juicy details.
Related issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/12415
See merge request !2613
2016-01-27 21:20:16 +00:00
Robert Speicher
614025da38
Merge branch 'rs-skip-2fa-on-signout' into 'master'
...
Skip the 2FA requirement during logout
See merge request !2581
2016-01-27 21:17:31 +00:00
Robert Speicher
56538f9cc1
Merge branch 'fix/unexistent-group-500' into 'master'
...
Return a 404 instead of a 500 when accessing a non-existent group
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/3352
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/5600
See merge request !2614
2016-01-27 20:19:35 +00:00
Dmitriy Zaporozhets
7e6da7b91a
Merge branch 'rs-2fa-requirement-wording' into 'master'
...
Update wording for 2FA requirement notice
See merge request !2582
2016-01-27 19:04:44 +00:00
James Lopez
afde800b25
Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into fix/unexistent-group-500
2016-01-27 11:35:13 +01:00
James Lopez
eef9c9d447
update fix based on feedback
2016-01-27 10:44:24 +01:00
James Lopez
d6a186135f
fix for failing spec
2016-01-26 15:43:09 +01:00
Douwe Maan
28e2d2142c
Merge branch 'rs-groups-index' into 'master'
...
Make the `/groups` route behave as expected
The route is supposed to redirect the Groups#index request based on
whether or not a user was logged in. If they are, we redirect them to
their groups dashboard; if they're not, we redirect them to the public
Explore page.
But due to overly aggressive `before_action`s that weren't excluding (or including) the
`index` action, the request always resulted in a 404, whether a user was
logged in or not.
Closes #12660
See merge request !2580
2016-01-26 11:59:05 +00:00
James Lopez
89aeed183c
feature and fix for 500 on group missing
2016-01-26 12:16:47 +01:00
Yorick Peterse
128a6411d2
Don't pluck project IDs for events
...
By instead using a sub-query we save ourselves the overhead of loading
any data into memory only to pass it on to another query.
2016-01-26 10:51:53 +01:00
Douglas Barbosa Alexandre
46c36e0e01
Fixi import redirect loop
2016-01-25 21:00:23 -02:00
Robert Speicher
fcab1345da
Update wording for 2FA requirement notice
2016-01-23 17:56:18 -08:00
Robert Speicher
fdf68a8d4d
Skip the 2FA requirement during logout
2016-01-23 16:44:46 -08:00
Robert Speicher
a7c4d0da8c
Make the /groups route behave as expected
...
The route is supposed to redirect the Groups#index request based on
whether or not a user was logged in. If they are, we redirect them to
their groups dashboard; if they're not, we redirect them to the public
Explore page.
But due to overly aggressive `before_action`s that weren't excluding the
`index` action, the request always resulted in a 404, whether a user was
logged in or not.
Closes #12660
2016-01-23 16:10:13 -08:00
Dmitriy Zaporozhets
56b527093d
Merge branch 'fix-comment-on-diff-ajax-loading'
2016-01-22 10:20:19 -08:00
Robert Speicher
5f0d7e2e3b
Merge branch 'fix-mr-diff-edit-button' into 'master'
...
Fix MR diff 'Edit' button
It now works and has the right size.
See merge request !2542
2016-01-22 07:39:33 +00:00
Douwe Maan
150b4f66e6
Make sure non-highlighted diffs are still escaped
2016-01-22 01:47:17 +01:00
Douwe Maan
9369b7ec1f
Fix MR diff 'Edit' button
2016-01-21 22:46:49 +01:00
Rémy Coutable
8a829c9738
Merge remote-tracking branch 'origin/master' into fix-comment-on-diff-ajax-loading
2016-01-20 22:42:07 +01:00
Rubén Dávila
985297d82a
Merge branch 'master' into issue_3945
2016-01-20 15:07:00 -05:00
Robert Speicher
1553c560e0
Merge branch 'feature/check-against-rbl-only' into 'master'
...
Split from !2455
References #9092
See merge request !2515
2016-01-20 14:24:20 -05:00
Douwe Maan
7d347ae564
Merge branch 'master' into issue_3945
2016-01-20 20:04:15 +01:00
Douwe Maan
577f2fb47a
Save and use actual diff base commit for MR diff highlighting
2016-01-20 18:44:27 +01:00
Douwe Maan
0ad6b44a27
Send user context to Sentry
2016-01-20 16:15:19 +01:00
Tomasz Maczukin
8536e083f7
Add IP blocking against DNSBL at sign-up
2016-01-20 15:28:19 +01:00
Douwe Maan
c23ca0b0b5
Merge branch 'master' into issue_3945
2016-01-20 14:53:41 +01:00
Rémy Coutable
491c2248c0
Fix diff comments loaded by AJAX to load comment with diff in discussion tab
...
This commits also fixes two minor issues:
- Ensure notes that the current user is not allowed to see are not
returned in the AJAX notes loading
- Ensure the notes counter badge is decremented of 1 instead of 2
2016-01-19 18:22:01 +01:00
Jeroen Nijhof
85e0fce9ee
Add sentry integration
2016-01-18 17:15:10 +01:00
Josh Frye
c70ed7f2cd
Autofill abuse message text with user url. Closes #2838
2016-01-16 10:47:12 -05:00
Robert Speicher
8a028cf3a2
Merge branch 'fix-autocomplete-new-issues' into 'master'
...
Fix autocomplete for new issues/MRs/snippets
Fixes gitlab-org/gitlab-ce#8067
See merge request !2446
2016-01-15 20:57:56 +00:00
Douwe Maan
57d8faf662
Merge branch 'feature/allow-artifacts-for-reporters' into 'master'
...
Allow access to artifacts for users with reporter role
This is originally introduced by @ajohnsn in this merge request: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2259
I've added and refactored specs, original commit by @ajohnsn has been cherry picked here.
See merge request !2448
2016-01-15 15:53:34 +00:00
Drew Blessing
4bc7d6e3c1
Merge branch 'issue_7975' into 'master'
...
Consider that URL can end with '/' before redirecting.
Closes #7975
See merge request !2416
2016-01-15 14:02:55 +00:00
Grzegorz Bizon
6b2f38f39a
Fix nonexistent method in artifacts controller
2016-01-15 13:48:29 +01:00
Andrew Johnson and Grzegorz Bizon
f66f9e95bf
Give reporters the ability to download artifacts.
...
Also fix a few places where page_404 should be render_404.
2016-01-15 12:01:19 +01:00
Yorick Peterse
f7240e03a6
Fix autocomplete for new issues/MRs/snippets
2016-01-15 11:29:53 +01:00
Rubén Dávila
c8db25c37c
Merge branch 'master' into issue_3945
2016-01-14 17:28:44 -05:00
Rubén Dávila
6b9c730e91
More refactoring from last code review. #3945
...
* Use commit objects instead of IDs when generating diffs
* Use proper references when generating MR's source and target
* Update broken specs
2016-01-14 16:47:55 -05:00
Rubén Dávila
70bc322415
Use the adequate reference for the old rev. #3945
2016-01-14 16:41:10 -05:00
Douwe Maan
8dfad143d4
Add inline diff markers in highlighted diffs.
2016-01-14 22:28:07 +01:00
Douwe Maan
b6ae2def2c
Merge branch 'unsubscribe-from-thread-from-email-footer' into 'master'
...
Unsubscribe from thread through link in email footer
Closes #3437


See merge request !2068
2016-01-14 14:38:55 +00:00
Grzegorz Bizon
6b0a43aff3
Improve readability of artifacts browser Entry related code
2016-01-14 12:48:17 +01:00
Grzegorz Bizon
487b0a026f
Improvements, readability for artifacts browser
2016-01-14 12:48:16 +01:00
Grzegorz Bizon
e9c2628220
Check if file exists in metadata in download action
2016-01-14 12:48:16 +01:00
Grzegorz Bizon
09a4a5aff8
Render only valid paths in artifacts metadata
...
In this version we will support only relative paths in artifacts
metadata. Support for absolute paths will be introduced later.
2016-01-14 12:48:16 +01:00
Grzegorz Bizon
61fb47a432
Simplify implementation of build artifacts browser (refactoring)
2016-01-14 12:48:15 +01:00
Grzegorz Bizon
cd3b8bbd2f
Add method that checks if path exists in StringPath
2016-01-14 12:48:15 +01:00
Grzegorz Bizon
a5e1905d28
Render 404 when artifacts path is invalid
2016-01-14 12:48:15 +01:00
Grzegorz Bizon
a7f99b67a0
Extract artifacts metadata implementation to separate class
2016-01-14 12:48:15 +01:00
Grzegorz Bizon
3de8a4620a
Parse artifacts metadata stored in JSON format
2016-01-14 12:48:15 +01:00
Grzegorz Bizon
447f56036e
Use metadata stored in artifacats metadata file
2016-01-14 12:48:14 +01:00