Commit Graph
21625 Commits
Author SHA1 Message Date
Andrey 37a4e4945d Merge branch 'fix-profile-nav' into 'master'
Make profile navigation full wide

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

## Before


![Administrator___GitLab](/uploads/a43e8992264ed78afa732e7a911ef154/Administrator___GitLab.png)

## After

![Administrator___GitLab1](/uploads/9e67e8af071d4879045311abe15a7bba/Administrator___GitLab1.png)

See merge request !2076
2015-12-16 10:57:02 +00:00
Robert Speicher 5ffed49fef Merge branch 'lazy-reference-extractor' into 'master'
Move Markdown/reference logic from `Gitlab::Markdown` to `Banzai`

- Moves from `Gitlab::Markdown` to `Banzai`
- Moves filters and pipelines into their own namespace: `Banzai::Filter` and `Banzai::Pipeline`
- No more `autoload`!
- Split up `Gitlab::ReferenceExtractor` into `Banzai::ReferenceExtractor` and `Gitlab::ReferenceExtractor`
- Replace `something(load_lazy_references: true)` by `Gitlab::ReferenceExtractor.lazily { something }`

Goes from:

```ruby
def referenced_merge_requests
  references = [self, *notes].flat_map do |note|
    note.all_references(load_lazy_references: false).merge_requests
  end.uniq!

  Gitlab::Markdown::ReferenceFilter::LazyReference.load(references).uniq.sort_by(&:iid)
end
```

to

```ruby
def referenced_merge_requests
  Gitlab::ReferenceExtractor.lazily do
    [self, *notes].flat_map do |note|
      note.all_references.merge_requests
    end
  end.sort_by(&:iid)
end
```

See merge request !2027
2015-12-15 20:52:04 +00:00
Robert Speicher 28a8d0b5db Merge branch 'add_user_repo_integrity_rake_task' into 'master'
Add user repository integrity check rake task

Corrupt repositories and stuck lock files can cause weird issues in
GitLab. Often we know which user is having these problems and then we
have to go hunt down which repository is causing it. Several times
recently that involved me running queries in the rails console to get
an array of projects and then writing a quick Ruby script to loop
through and run `git fsck`. This last time I also had to check for the
existence of `config.lock` and ref lock files. 

This rake task will eliminate all of those steps and allow an admin to
simply specify a username.

I also added the lock file checks to the existing `gitlab:repo:check`
task which goes through all projects. 

See merge request !2080
2015-12-15 18:36:28 +00:00
Andrey 96a1558897 Merge branch 'wider-layout' into 'master'
Increase fixed layout width to 1280px

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

cc @creamzy 

See merge request !2075
2015-12-15 18:19:55 +00:00
Dmitriy Zaporozhets ee258322f5 Merge branch 'fix-panel-height' into 'master'
Fix inline panel heading height

The `line-height` was added so that headings in the panels on the settings page had the same height as headings elsewhere, but the style applied everywhere :)

Before:

(Look at the "Unstarted Issues" heading)

![Screen_Shot_2015-12-15_at_17.39.46](/uploads/9dbea4c8b28e3c43bb5d4b5226d7a1ec/Screen_Shot_2015-12-15_at_17.39.46.png)

![Screen_Shot_2015-12-15_at_17.40.19](/uploads/97898418e9a66954c02e8a68b21c08b9/Screen_Shot_2015-12-15_at_17.40.19.png)

After:

![Screen_Shot_2015-12-15_at_17.40.45](/uploads/5748aba032889053dd778b39e96fa301/Screen_Shot_2015-12-15_at_17.40.45.png)

![Screen_Shot_2015-12-15_at_17.40.40](/uploads/20240cdc7a6d5665cd32556d1a0e6c1d/Screen_Shot_2015-12-15_at_17.40.40.png)

cc @skyruler 

cc @rspeicher 8.3 please!

See merge request !2106
2015-12-15 17:53:34 +00:00
Douwe Maan f31dfae28a Fix inline panel heading height 2015-12-15 17:31:07 +01:00
Douwe Maan 6560d053ed Use lazy reference extractor to get issue's MRs 2015-12-15 16:57:11 +01:00
Douwe Maan 48b3ad6d37 Banzai::XFilter -> Banzai::Filter::XFilter 2015-12-15 16:10:32 +01:00
Douwe Maan 7781bda9bd Move Markdown/reference logic from Gitlab::Markdown to Banzai 2015-12-15 15:51:16 +01:00
Grzegorz Bizon 4493d3fd55 Merge branch 'tests/note-polling' into 'master'
Add feature specs for note polling

Ref. #4032, !2084

cc @rspeicher 

See merge request !2086
2015-12-15 14:02:28 +00:00
Grzegorz BizonandGrzegorz Bizon 8fe821cfa5 Trigger notes refresh in specs instead of waiting for ajax 2015-12-15 14:19:35 +01:00
Grzegorz BizonandGrzegorz Bizon 6fb120d1b0 Assign notes object to a variable 2015-12-15 14:19:35 +01:00
Grzegorz BizonandGrzegorz Bizon 3e789eab8b Add minor fixes in note polling specs 2015-12-15 14:19:35 +01:00
Grzegorz BizonandGrzegorz Bizon 9470d05c70 Add spinach test for note polling
This also increases capybara timeout to 15 seconds (note polling
interval). Capybara will look for new note for this period of time.
2015-12-15 14:19:35 +01:00
Grzegorz BizonandGrzegorz Bizon 7c14541d2b Add feature specs for note polling
Ref. #4032, !2084
2015-12-15 14:19:35 +01:00
Douwe Maan 9451db3819 Merge branch 'rs-issue-4032' into 'master'
Fix note polling

Closes #4032

See merge request !2084
2015-12-15 13:18:13 +00:00
Robert Speicher 2b4a3bc524 Merge branch 'preserve-trailing-new-lines-at-eof' into 'master'
Preserve trailing new lines at the end of file on the online editor

Fixes #3784

Because Haml automatically indents the HTML source code, the contents
of whitespace-sensitive tags like pre and textarea can get screwed up.

See merge request !2099
2015-12-14 23:29:50 +00:00
Achilleas Pipinellis f28c2de41f Merge branch 'contributing_md' into 'master'
Clean up CONTRIBUTING.md

* Use 80 chars width where possible
* Remove easyfix label reference
* Add new issue submission template
* Add long links to the bottom of the page

See merge request !2100
2015-12-14 23:24:07 +00:00
Achilleas Pipinellis 1c7128f34c Fix links [ci skip] 2015-12-15 00:44:02 +02:00
Achilleas Pipinellis 2e54428171 Clean up CONTRIBUTING.md [ci skip]
* Use 80 chars width where possible
* Remove easyfix label reference
* Add new issue submission template
* Add long links to the bottom of the page
2015-12-15 00:17:25 +02:00
Drew Blessing f8bf6c4b2c [ci skip] Add user repository integrity check rake task 2015-12-14 15:27:14 -06:00
Douglas Barbosa Alexandre 5afe03315d Preserve trailing new lines at the end of file on the online editor
Because Haml automatically indents the HTML source code, the contents
of whitespace-sensitive tags like pre and textarea can get screwed up.
2015-12-14 18:22:28 -02:00
Achilleas Pipinellis e7d7cd67bb Clarify what CE and EE means for newcomers 2015-12-14 22:07:53 +02:00
Achilleas Pipinellis b95f7b1864 Merge branch 'feature-proposal' into 'master'
update guides for feature proposals on the issue tracker

see also #4038 

cc @sytses 

See merge request !2094
2015-12-14 20:00:57 +00:00
Robert Schilling f7af7c993b Merge branch 'fix-typo-mailing-list' into 'master'
Fix Typo [mailinglist to mailing list]

Closes: #4078 

See merge request !2098
2015-12-14 19:49:51 +00:00
Mrinal 829dc1493c Fix Typo [mailinglist to mailing list] 2015-12-14 19:46:41 +00:00
Job van der Voort 5fb1fd27aa move up text regarding where to post issue 2015-12-14 20:22:06 +01:00
Robert Speicher 381a9951e9 Update 8.2-to-8.3 guide
[ci skip]
2015-12-14 13:17:23 -05:00
Robert Speicher 63f58c4929 Merge branch 'add-upgrade-guide-for-8-3' into 'master'
Add upgrade guide for 8.2 to 8.3

Making sure we don't forget mentioning the need to upgrade Redis from
!1888. Added this in preparation for 8.3.

[ci skip]

See merge request !2085
2015-12-14 17:54:09 +00:00
Robert Speicher 739ce7883a Prepare Installation doc for 8.3.0-rc1
[ci skip]
2015-12-14 12:28:58 -05:00
Stan Hu b9b35012de Update gitlab-workhorse and remove mention of gitlab-git-http-server
[ci skip]
2015-12-14 09:23:53 -08:00
Stan Hu 5bca9ec750 Rename gitlab-git-http-server mention with gitlab-workhorse
[ci skip]
2015-12-14 09:21:18 -08:00
Stan Hu 58bb985fe0 Add upgrade guide for 8.2 to 8.3
[ci skip]
2015-12-14 09:21:18 -08:00
Grzegorz Bizon 4526515704 Merge branch 'ux/suppress-ci-yml-warning' into 'master'
Suppress warning about missing `.gitlab-ci.yml` if builds are disabled

When user disables GitLab Ci Service in project's settings then warning
about missing `.gitlab-ci.yml` file should be supressed. This a matter
of user experience as stated in #3761 (closes #3761).

cc @ayufan 

See merge request !2014
2015-12-14 17:16:29 +00:00
Grzegorz Bizon 0a81a68158 Update CHANGELOG
[ci skip]
2015-12-14 18:15:11 +01:00
Grzegorz Bizon 3fb89a36cb Merge branch 'ci/persist-registration-token' into 'master'
Persist CI runners registration token

This MR adds feature of persisting CI runners registration token.
User will be able to generate and then reset (if necessary to revoke) this token.

This closes #3703 

cc @ayufan 

See merge request !2039
2015-12-14 13:27:29 +00:00
Grzegorz Bizon 9d2b8326b2 Update commits spinach tests related to displaying build status 2015-12-14 14:25:18 +01:00
Grzegorz Bizon 6586856a15 Use a new admin runners path when reseting runners token 2015-12-14 14:03:58 +01:00
Grzegorz Bizon 76a17d4f54 Merge branch 'master' into ci/persist-registration-token
* master:
  Move CI admin builds and runners specs to correct directory
  Fix 500 when viewing specific runners on runners page
  Fix Ci::Project migration not migrating columns that cannot be NULL
  Fix MySQL migration of CI emails
  Minor fix in flow 'Merge when build succeeds'
2015-12-14 13:00:25 +00:00
Kamil Trzciński 73ba411af9 Merge branch 'move-ci-specs-to-admin-features' into 'master'
Move CI admin builds and runners specs to correct directory [ci skip]

/cc @grzesiek 

See merge request !2095
2015-12-14 12:08:34 +00:00
Kamil Trzcinski c0ff4fdd99 Move CI admin builds and runners specs to correct directory [ci skip] 2015-12-14 13:06:59 +01:00
Job van der Voort 5ea5494af6 update guides for feature proposals on the issue tracker 2015-12-14 13:06:16 +01:00
Kamil Trzciński 1859b10617 Merge branch 'fix-ci-project-migration' into 'master'
Fix CI project migration and 500 on runners page



See merge request !2093
2015-12-14 11:51:35 +00:00
Kamil Trzcinski cb4b4c5786 Fix 500 when viewing specific runners on runners page [ci skip] 2015-12-14 12:46:26 +01:00
Kamil Trzcinski 927c40ca49 Fix Ci::Project migration not migrating columns that cannot be NULL [ci skip] 2015-12-14 12:31:35 +01:00
Grzegorz Bizon 2ec93abed7 Merge branch 'master' into ci/persist-registration-token
* master: (66 commits)
  Fix runners admin view
  Fix migrations
  Rename mention of gitlab-git-http-server to gitlab-workhorse
  Bump Redis requirement to 2.8 for Sidekiq 4 requirements
  Fix wording on runner setup page
  add details on how to change saml button label
  Fix tests
  Move awards back to gray panel and few improvements to sidebar
  Few UI improvements to new sidebar implementation
  Fix tests for new issuable sidebar
  Update changelog
  Implement new sidebar for merge request page
  Make edit link on issuable sidebar works
  Redesign issue page for new sidebar
  Move awards css to separate file
  Implement issuable sidebar partial
  Update CHANGELOG
  Clarify cache behavior
  Run builds from projects with enabled CI
  Use Gitlab::Git instead of Ci::Git
  ...

Conflicts:
	db/schema.rb
2015-12-14 12:26:40 +01:00
Grzegorz Bizon 32d83ee79f Merge branch 'master' into ux/suppress-ci-yml-warning
* master: (24 commits)
  Fix runners admin view
  Fix migrations
  Run builds from projects with enabled CI
  Use Gitlab::Git instead of Ci::Git
  Fix last specs
  Fix specs
  Fix after column rename
  Fix errors
  Update badge
  Finishing touches
  Fix triggers tests
  Rename columns and rename migrations
  Reimplement Trigger API
  Remove ci_ prefix from all ci related things
  Add runners token
  Migrate CI::Project to Project
  Fix indentation and BuildsEmailService
  Change default values
  Enhance migrate CI emails
  Fix issue tracker service
  ...

Conflicts:
	spec/features/commits_spec.rb
2015-12-14 12:25:37 +01:00
Kamil Trzcinski 208f99ff6c Fix MySQL migration of CI emails [ci skip] 2015-12-14 12:04:26 +01:00
Douwe Maan 45593d574c Merge branch 'tweak-flow-merge-when-build-succeeds' into 'master'
Minor fix in flow 'Merge when build succeeds'

When a user, which is not the merge user, want to removes the source branch
after the automatic merge this might fail because of checks in the
DeleteBranchService

/cc @DouweM 

See merge request !2070
2015-12-14 11:00:44 +00:00
Kamil Trzciński c810234357 Merge branch 'ci-project-migrate' into 'master'
Ci Project migrate

- This doesn't migrate: allow_git_fetch, coverage_regex, timeout. Since this are project configuration settings I would propose to migrate them to `.gitlab-ci.yml`.
- This requires offline migrations.
- It simplifies database models making all CI objects to be attached to: Project.
- It removes Ci::Project, but makes /ci/projects working by adding method: Project.find_by_ci_id for backward compatibility (badges, triggers).
- We should add default `timeout` to Application Settings.
- It misses specs.
- It is based on ci-services-migrate for now.
- It removes CI events.
- It removes administrator CI projects overview.
- It removes CI application settings.

In 8.4 or 8.5 we can remove redundant tables and columns.


See merge request !1987
2015-12-14 10:35:40 +00:00