Enable rubocop metrics
This enables rubocop metrics like CyclomaticComplexity and ABCSize.
Initial threshold values are high, should be probably decreased.
See merge request !1802
Fix award-emojis alert flash message
This adds a new feature to `Flash` that allows to pin it after a
specified selector. This removes a fixed position from such award-emoji
alert, and makes it responsive by design of selector that this alert is
pinned to.
Closes#3996
\cc @vsizov
See merge request !2065
This adds a new feature to `Flash` that allows to pin it after a
specified selector. This removes a fixed position from such award-emoji
alert, and makes it responsive by design of selector that this alert is
pinned to.
Closes#3996
Expand character set of usernames created by Omniauth
When a user is created by Omniauth, Gitlab tries to assign the username based on the information provided in the auth hash. If no nickname is present, it uses the part of the email address before the @. This portion of the email address is run through the `parameterize` method, presumably to convert Unicode characters to ASCII.
`parameterize` strips out a number of characters that are valid in usernames. For example, `john.doe` is a valid Gitlab username, but parameterize will turn this into `john-doe`.
Instead of `parameterize`, this merge request uses `normalize` to convert non-ascii characters. This allows all acceptable characters to be used when creating a username from an email address.
See merge request !660
Remove check icon from merged MRs
Now that GitLab CI exposes the status of each MR in the MR page it seems "redundant" to have an extra icon next to the CI statuses.
The "downside" is with people that don't use CI and don't see the statuses, but I don't think that this is that big a change that would miss to anyone.
\cc @dzaporozhets @creamzy
How it looks now:
See merge request !2059
Document file upload random uuid security
This documents the current state of file uploads regarding random UUID and security.
Fixes#3569
Thanks to @DouweM for the language.
cc/ @sytses @JobV @axil Does this look OK?
See merge request !2055
Upgrade Sidekiq to 4.x
Upgraded Sidekiq to 4.x.
More details can be found here: #3065
After merging this MR, we will require Redis 2.8+.
@stanhu have made a MR !1888 to reflect needed changes on our documentation.
See merge request !2057
[Second try] Implement different Markdown rendering pipelines and cache Markdown
!1602 already got merged in bcd89a58e7, but it would appear the merge commit disappeared because of #3816 (or some other reason).
cc @rspeicher
See merge request !2051
Enable Devise paranoid mode and ensure the returned message is the same
every time. This will prevent user enumeration (low impact).
Prior to this change a user could type an email in the password reset
field and if the email didn't exist it returned an error. If the email
was valid it returned a message saying the forgot password link had been
emailed. After this change the user will receive a message that if the
email is in our database the reset link will be emailed.
I also changed the throttle mechanism so it still works the same but
now returns the exact same message as above. Previously it would say
'You've already sent a request. Wait a few minutes'. This also allows
user enumeration, although it requires a double-check.
Related to https://dev.gitlab.org/gitlab/gitlabhq/issues/2624
See merge request !2044
Fix list with controls display
Introduced in !2025
## Before
## After
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
See merge request !2048
Robert Speicher
Douwe Maan
Grzegorz Bizon
Grzegorz Bizon
Valery Sizov
Stan Hu
Dmitriy Zaporozhets
Douglas Barbosa Alexandre
Corey Hinshaw
Achilleas Pipinellis
Robert Speicher
Gabriel Mazetto
Drew Blessing
Zeger-Jan van de Weg
Borja Aparicio
Kamil Trzciński