Rubocop: require space round operators
This enables rubocop to require space around opertators and fix offenses in the codebase.
There is another merge-request to solve remaining offenses in EE codebase, merge it first: gitlab-org/gitlab-ee!388
Fixes#17398
See merge request !4112
Reduce width of side nav
Closes#17338
Part of #14838
Left: old; Right: new
<img src="/uploads/7dba5f22d6bdf1249bab5166addb25b5/Screen_Shot_2016-05-10_at_4.34.07_PM.png" width="500px">
See merge request !4109
Fix UI issues caused by header height decrease to 50px
- fix blank spacing for issue sidebar
- fix login btn alignment for non logged in users
See merge request !4143
Remove background color differentiation from gitlab logo/text in sidebar
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
cc @annabeldunstone @skyruler
See merge request !4139
Enable the Rubocop DeprecatedClassMethods cop
This reports uses of `File.exists?` and `Dir.exists?`, which were both
deprecated in Ruby and will eventually be removed in favor of `.exist?`.
Also fixes all existing uses of the deprecated methods.
See merge request !4087
Fix a description for default scope on builds
Should be "**All* builds (from this project)" for the {project,admin}
builds page without scope.
Fix a regression on !2243 (#4240).
See merge request !4118
Update build log incrementally
Proof of concept implementation of incremental sending of build log to browser.
cc @jschatz1 @vsizov @grzesiek @tmaczukin
See merge request !3737
Only show forks for users who can download code
The ForksController enforces this, so don't show the link if it won't go anywhere.
Closes#14272.
See merge request !4017
Reuse runners edit form in admin and project area
Reuse runners edit form in admin and project area.
See merge request !4094
Removed tracking of total method execution times
See #17239 and 945c5b3fe6 for more details. The Grafana dashboards used to visualize performance data were updated a while ago to no longer display this data.
See merge request !4124
Group commits by date in server timezone
`Time#to_date` just takes the (timezone-less) year, date, and month, and
creates a new date from that. Because the commits in the list are
grouped by date, rather than chunked when the date changes, a commit can
be shown in the wrong order if its CommitDate has a timezone-less date
that's different to other commits around it.
Convert all CommitDates to the server timezone before grouping, as that
will at least produce consistent results. Users can still see a
timestamp on the commit that doesn't match the date it's grouped under,
because the timestamp shown uses the user's local timezone, and the
grouping uses the server's timezone, but that was an issue anyway.
### Before
### After
Closes#3870 and closes#17300.
See merge request !4052
Update cas.md to reflect the current syntax, and added that gitlab-ctl reconfigure should be run.
I spent a while trying to figure our why the cas wasn't working!
Someone may need to update the source code section of the wiki
See merge request !3850
Because method call timings are inclusive (that is, they include the
time of any sub method calls) this would lead to the total method
execution time often being far greater than the total transaction time.
Because this is incredibly confusing it's best to simply _not_ track the
total method execution time, after all it's not that useful to begin
with.
Fixesgitlab-org/gitlab-ce#17239
This reverts commit 78a832d0fd7ff445c707809134dbb2a42d2a9e03.
Show help only for the enabled OAuth Providers on oauth-providers-help block
aria: { describedby: help_block_id } instead of 'aria-describedby' => help_block_id
provider and not p
a more simple approach to the OmniAuth helper links for oauth-providers-help
Robert Speicher
Dmitriy Zaporozhets
Annabel Dunstone
Gabriel Mazetto
Douwe Maan
Drew Blessing
Robert Speicher
Douwe Maan
Ahmad Sherif
Jacob Schatz
Takuya Noguchi
Yorick Peterse
Rémy Coutable
DJ Mountney
Sean McGivern
Kamil Trzcinski
Marin Jankovski
Andrei Gliga