Use dedicated methods for counting branches and tags
This started out as "Lets add two methods to count and cache some data" and ended up in a clean-up/fix of some existing code. The two problems were:
1. Different code was used for adding/removing branches/tags via Git and the UI
2. The code used for the UI didn't have any RSpec tests, and I couldn't find any Spinach tests either (though grepping for Spinach stuff is hard)
This MR addresses the following:
1. `Repository#branch_count` and `Repository#tag_count` are used to count and cache the number of branches/tags, these methods are then used on the branches/commits/tags pages.
2. `Repository#add_tag`, `Repository#add_branch`, `Repository#rm_tag` and `Repository#rm_branch` now all the appropriate before/after hook methods instead of calling a random single cache expiration method. This ensures caches are properly flushed when adding/removing tags/branches via the UI.
3. RSpec tests were added for the above methods.
This fixes gitlab-org/gitlab-ce#13459
See merge request !3128
The methods used for this are Repository#tag_count and
Repository#branch_count which cache their output in Redis as well as
memoizing it in an instance variable. Both methods have a corresponding
methods/hooks to flush the caches at the right time.
update slack instructions
the previous instructions no longer apply, there is no "Incoming WebHooks" row anymore.
luckily there exists direct link to web hooks, so the previous steps aren't even neccessary
See merge request !3052
Deprecated GitLab CI API clean up
Deprecated GitLab CI API clean up.
The intent here is to clean up deprecated GitLab CI documentation leaving only relevant information.
Since we merged `Ci::Project` to `Project` most of this documentation is outdated.
Closes#13610
See merge request !3003
add bundle clean to upgrade docs
This MR adds a bundle clean after installing new gems. Bundle clean removes old, not needed gems to keep the system clean.
See merge request !2809
Added Troubleshooting information for most used services.
This replaces the changes started at gitlab-com/www-gitlab-com!1603
I'd like to add similar troubleshooting information for EE only services, but that needs to happen on a different MR on the EE side. Probably after this one gets merged.
cc @ernstvn @dblessing @balameb @cabargas @kelvinmutuma
See merge request !3080
Remove redundant integration tests
These three tests were essentially checking that adding a note to
something updated its `noteable`'s `updated_at` attribute.
This is well-tested Rails behavior and we shouldn't feel the need to
write an integration test to verify it. At most we should be ensuring
that the association definition adds the `touch: true` option, which we
now do in Note's unit test.
See merge request !3117
Set cache headers for raw blobs
This changes allows browsers and (in the case of public projects)
proxy caches to cache raw Git blob responses.
See merge request !3113
Douglas Barbosa Alexandre
Rémy Coutable
Yorick Peterse
Achilleas Pipinellis
Dmitriy Zaporozhets
Jonas Friedmann
Robert Speicher
Robert Speicher
Yatish MehtaandRémy Coutable
Douwe Maan
Patricio Cano
tiagonbotelhoandYorick Peterse