make some changes for the checks to determine when the messages should be displayed
add item to changelog and also integration test
make some changes to the test
make some changes
Load the "New Branch" button asynchronously
Here's how it looks like for logged in users:
And here it is for anonymous users (or when a new branch can't be created by a logged in user):
See merge request !3855
This button depends on Issue#can_be_worked_on? which in turn depends on
Issue#related_branches. By rendering this button asynchronously we can
finally remove all usages of Issue#related_branches and
Issue#referenced_merge_requests from the issues "show" page.
Enable the UrlFormat and UrlQuotes SCSS Linters.
There were no lints to fix for this one, so it's just preventative.
UrlFormat: URLs should be valid and not contain protocols or domain names.
UrlQuotes: URLs should always be enclosed within quotes.
cc: @jschatz1
See merge request !3770
Project group UI
Closes#13991
See merge request !3911
Disable Rack Attack if admin disables it in config file
Grack::Auth already checks this variable. These holdouts were not disabled, leading to confusion when debugging a customer issue.
See merge request !3918
Prepend letter v to GitLab Workhorse version numbers
This helps to address gitlab-org/gitlab-ce#12684 so as to maintain consistency in all GitLab projects.
It also addresses: https://gitlab.com/gitlab-org/gitlab-workhorse/issues/4
Next Steps
- create a set of duplicate tags in workhorse to prevent errors when updating from the patch guide
See merge request !3088
Build status `canceled` if any of the jobs canceled
Before this change in case of any of the jobs had been canceled, build status was `failed`.
Closes#14207
See merge request !3778
Use ActionDispatch Remote IP for Akismet checking
Previously all remote IPs appeared at 127.0.0.1, which made Akismet
not very useful. Using the ActionDispatch Remote IP (http://api.rubyonrails.org/classes/ActionDispatch/RemoteIp.html)
should provide more reliable results.
Closes#16629
See merge request !3961
Backport GitHub Enterprise import support from EE
These changes were pulled from GitLab EE to support configuring
an alternative API URL than the default https://api.github.com.
In addition, the `verify_ssl` flag allows users to disable SSL cert
checking.
One modification: add a default `args` option if it does not exist
to avoid breaking existing configurations.
See merge request !3892
Add JS prefix to user tab classes
## What does this MR do
This MR adds the `js-` prefix to the classes which are used for js purposes only. This MR only affects the said classes inside `users/show.html.haml`.
## Are there points in the code the reviewer needs to double check?
I'm not entirely sure if this project uses the `js-` prefix for
classes that are used for js purposes only. Doing a grep shows some of the classes have the prefix, but I'm still unsure whether this project follows this rule.
## Why was this MR needed?
As I was working thru #13401, I wanted to add a tab on the user profile page to show the contributions outside the GitLab instance. Reading the JS, I came across this. This MR helps new people reading the code that the said classes are for js purposes only. Also, it helps the project work toward to uniform class naming.
I suggest that we document adding the `js-` prefix to classes for js purposes only (if this is the case for this project)
See merge request !3928
Add API doc example with query string for triggering build
Make this explicit to prevent confusion as we saw in gitlab-org/gitlab-ci#413.
See merge request !3947
Project title dropdown tests
Added a test for when on an issue page to check whether the project
dropdown links will still work
See !3870
See merge request !3921
Rémy Coutable
Yorick Peterse
Jacob Schatz
Grzegorz Bizon
Arinde Eniola
Robert Speicher
Dmitriy Zaporozhets
Zeger-Jan van de Weg
Jacob Vosmaer (GitLab)
Achilleas Pipinellis
Jacob Vosmaer
Stan Hu
Alfredo Sumaran
Annabel Dunstone