Support e-mail notifications for comments on project snippets
While working with project snippets recently, I noticed that notifications would not be sent out for comments on notes. This MR fixes this.
Note: I'm not completely sure why `ProjectSnippets#participants` returns an empty array if you don't include the concern that is already in `Snippets` but didn't dig into it any more.
Closes#2334
See merge request !3987
Fix "remember me" sign in option
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/4006
Prior to this change, 'remember me' was effectively always on because
the `_gitlab_session` cookie was always made persistent. With this
change it becomes possible again to have `_gitlab_session`be a session
cookie when 'remember me' is unchecked.
See merge request !4004
Backported minimal safewebhook implementation to GitLab CE
This brings a minimal implementation for gitlab-org/gitlab-ce#13478
backported from EE (gitlab-org/gitlab-ee!334).
Also added UI to configure Secret Token
Fixes#15365.
See merge request !3940
Fix the GitHub Omniauth instructions
Technically the screenshot is also out of date, but I honestly don't care enough to go through the effort of making a sample application, taking a screenshot, etc.
See merge request !3976
Add more parameters to the filter_parameters config.
Adds Sentry DSN, Webhooks, Deploy Keys, etc.
Alphabetized the parameters and included line breaks between each parameter. Easier to merge into EE if there are any differences.
This also seems to be the more popular syntax for adding new parameters, from what I can find.
In the future we may want to [increase the specificity of some of these](http://blog.bigbinary.com/2016/03/07/parameter-filtering-enhacement-rails-5.html) once Rails 5 is out. e.g. instead of `:hook`, `"hook.url"` would be just as effective without removing potentially useful information from the logs.
cc: @stanhu
See merge request !3971
Adds Sentry DSN, Webhooks, Deploy Keys, etc.
Alphabetized the parameters and included line breaks between each parameter. Easier to merge into EE if there are any differences.
This also seems to be the more popular syntax for adding new parameters, from what I can find.
This changes 4 things:
1. Project#protected_branches_names has been renamed to
Project#protected_branch_names.
2. Project#open_branches uses a Set for the branch names as checking
values in a Set is faster than checking values in a (large) Array.
3. Some redundant code in Project#open_branches has been removed.
4. Project#protected_branch_names now uses #pluck instead of #map,
removing the need for loading entire DB records into memory.
James Lopez
Robert Speicher
Robert Speicher
Stan Hu
Rémy Coutable
Jacob Vosmaer
Dmitriy Zaporozhets
Gabriel Mazetto
Achilleas Pipinellis
Grzegorz Bizon
Connor Shea
Yorick Peterse
Drew Blessing