Re-generate Spring binstubs for updated version of Spring
Prevents output like this:
Array values in the parameter are deprecated. Please use a String or nil.
An Array was passed in from bin/rspec:3:in `load'
See merge request !3887
Updated HA docs and open to public
Closes https://dev.gitlab.org/gitlab/organization/issues/624
We still need to go through the old gitlab.com/standard/high-availability and move relevant docs over, plus do some docs on DRBD. However, I think this is a good volume for the first pass. Can we get this out there and then iterate?
cc/ @axil @patricio For your review, please.
See merge request !3579
Refactor Todos feature spec to be faster and less brittle
We now only create two Todos instead of 21 when testing pagination, and
we've updated the test to be less brittle when dealing with slower CI
environments.
See merge request !3889
We now only create two Todos instead of 21 when testing pagination, and
we've updated the test to be less brittle when dealing with slower CI
environments.
Move cherry-pick feature specs to proper directory
Cherry pick feature specs were located in `spec/feature/project` directory while we have `spec/feature/projects`.
Later location is consistent with our namespaces (we have `Projects::` namespace, not `Project::`).
See merge request !3875
Allow filtering by Owned projects on dashboard page
Closes#3799
See merge request !3762
Always read diff_view setting from the cookie
Prior, when the user had their view set to "parallel" and then visited a
merge request's changes tab _without_ passing the `view` parameter via
query string, the view would be parallel but the `Notes` class was
always instantiated with the default value from `diff_view` ("inline"),
resulting in broken markup when the form to add a line note was
dynamically inserted.
The cookie is set whenever the view is changed, so this value should
always be up-to-date.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14557 and https://gitlab.com/gitlab-org/gitlab-ce/issues/15285
See merge request !3732
Fix vulnerability that leaks private labels and milestones
## Summary
This fixes vulnerability that leaks information about private labels and milestones because of insecure direct object reference in issueable create service.
This affects merge requests and issues.
See https://gitlab.com/gitlab-org/gitlab-ce/issues/15439
## Fix
This MR introduces additional check that rejects labels and milestone that does not belong to the same project issue/merg request does.
## Further work
`IssuableBaseService` may benefit from encapsulating filters in separate class/module, which then may improve coherency in this class.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/15439
See merge request !1954
Tomasz Maczukin
Rémy Coutable
Robert Speicher
Jacob Schatz
Luke Howell
Robert Speicher
Achilleas Pipinellis
Stan Hu
Drew Blessing
Drew Blessing
Dmitriy Zaporozhets
Alfredo Sumaran
Phil Hughes
Grzegorz Bizon
Grzegorz Bizon