Bump gitlab-shell
Fix git over ssh errors 'fatal: protocol error: bad line length character'
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
cc @DouweM @patricio
See merge request !506
Revert "Preload lib/"
This reverts commit 5511a731bc.
The original commit added this because it also enabled threadsafety, a change which was itself later reverted in 66d6c80966, but this got left behind.
I don't fully understand the reasoning behind it so if I'm wrong, please tell me.
My reasoning for reverting it is that it messes with Rails' (and by extension Spring's) class reloading during development. When I was working in `lib/gitlab/markdown` and had to stop and restart the server every time I made a change, I didn't know it at the time, but this was why. That was a huge pain point.
If it's needed for production perhaps we could add a `if Rails.env.production?` clause around it so that it doesn't mess with development.
See merge request !1758
Fix broken file browsing with a submodule that has a relative link
## What does this MR do?
This MR fixes an error that occurs when browsing a submodule with a relative link.
### Are there points in the code the reviewer needs to double check?
I re-wrote the function because I was confused by how the first one was supposed to work. Please review if it's clearer.
### Why was this MR needed?
A 500 Error would occur when using the file browser on a repo with a submodule. Here's how to reproduce the bug:
1. Start a new project in GitLab.
2. Clone git://git.gniibe.org/gnuk/gnuk.git/ locally.
3. Push repo to new project.
4. Click on "Files" in the project.
The .gitmodules file:
```
[submodule "chopstx"]
path = chopstx
url = ../../chopstx/chopstx.git
```
### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)?
1. #775
2. #1385
3. https://github.com/gitlabhq/gitlabhq/issues/8153
4. https://github.com/gitlabhq/gitlabhq/issues/8881
5. https://github.com/gitlabhq/gitlabhq/issues/7554
See merge request !508
Move current user to the top of the list in author/assignee filter
### What does this MR do?
This MR puts the current user at the top of the user list in the author/assignee filters.
### Are there points in the code the reviewer needs to double check?
Is it best to do this in the JavaScript as it is in this MR, or are we better off adding an argument to the `/users` API to put the current user on top?
Also, I elected to put the current user after "Any" and "Unassigned"--it looked better. Do you agree?
### Why was this MR needed?
If you're trying to look for "Me" in the list, often you have to scroll down a long way to find yourself. Using the filter to find yourself is yet another step requiring the keyboard, and it's easy to forget that feature is available.
### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)?
#1321 and #1396
### Screenshots
Before:
After:
See merge request !505
Fix bug where Wiki pages that include a '/' were no longer accessible
### What does this MR do?
This MR fixes a regression that caused Wiki pages that included a '/' to no longer be accessible.
### Are there points in the code the reviewer needs to double check?
Are there cases that `wiki_helper.rb` doesn't handle?
### Why was this MR needed?
The upgrade from Rails v4.1.2 to v4.1.9 (76aad9b76e) caused slashes in a model ID to be escaped automatically. We can no longer use the built-in the URL helpers to generate the links for Wiki pages if we want to maintain support for slashes. There is no option to tell the formatter otherwise:
http://stackoverflow.com/questions/25031791/rails-4-1-2-to-param-escapes-slashes-and-breaks-app
The Rails code in question is here:
https://github.com/rails/rails/blob/4-1-stable/actionpack/lib/action_dispatch/journey/visitors.rb#L159
### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)?
#1363
See merge request !502
Move project file links to tab bar.
The sidebar was getting awfully crowded, so I moved the file links to the tab bar alongside Activity and Readme. Unlike Readme, these files are not actually loaded in a tab, but simply link to the relevant blob, because we don't want to unnecessarily load the potentially large changelog or contribution guide on every project page load.
See merge request !497
Corrected steps for creating a patch release
Added step to bump all versions (CE, EE, CI) every time there is a patch release and the reasoning behind it
See merge request !1754
Robert Speicher
Dmitriy Zaporozhets
Dmitriy Zaporozhets
Robert Schilling
Stan Hu
Douwe Maan
Christoph Dreis
Valery Sizov
Patricio Cano
