don't set LATEST_TAG automatically in patch update guide
As discussed in https://gitlab.com/gitlab-org/gitlab-ce/issues/2607, this removes the automatic setting of the LATEST_TAG variable in the update guide, because it could get set to rc versions.
Instead, a command was added to list all tags, with the most recent one being on the end of the list. Also a note was added to prevent users from updating to new minor/major versions because the tag list includes all tags.
[ci skip]
See merge request !1510
removed extra_sign_in_text examples for gitlab.rb [ci skip]
I removed the extra_sign_in_text option documentation. This is no longer needed because a welcome message aka. extra_sign_in_text can now be set/changed in the admin UI.
Admin area > Settings
This was mentioned in issue #3006
See merge request !1565
LDAP email address downcasing
Fixes#2960
In the event we cannot match an LDAP user by DN we attempt to find an identity by email address and then update the DN. In this case the identity is matched by email address.
If the user's email address in LDAP has an upper case character we cannot find a match in the GitLab database. GitLab downcases emails before the user object is saved.
This merge request downcases the email from LDAP before we lookup by email. I also added a test to prevent a regression.
See merge request !1550
Normalize space-like characters in keys before output to gitlab-shell
gitlab-shell expects only one tab separator per key, and an SSH key with
a tab character in the comment, for example, would break things.
Closes#2970
See merge request !1552
Make the loading spinner toggle more explicit
Occasionally the loading spinner would stay visible after the tab
finished loading. This change makes the toggle explicit so that it's
always shown on `beforeSend`, and always hidden on `complete`.
Plus a bonus semi-colon eradication! 💥
See merge request !1553
Clarify support request message
Since we have the (GitLab.com) Support Forum, this message may be slightly confusing. Hopefully this wording improves understanding. If anyone has suggestions on making this clearer I'm open.
See merge request !1406
Fixed positioning of hamburger menu on header
Hey guys just noticed the hamburger menu for the top navigation was mis-aligned on
`gitlab-ce:master` and `gitlab.com`.
I was not able to find an open issue or merge request directly referencing this issue so thought I would add a quick fix.
### Changes
This MR changes the vertical positioning from `top` to vertical margins (Like in bootstrap itself).
- Also added a minor fix to remove `border-top` from the collapse menu so its the same height as the navigation.
- finally added an active class to the hamburger toggle so you can see when its open.
This changes an element in `app/views/layouts/header/_default.html.haml` and thus would impact most pages behind login.
## Screenshots
### Before
### After
Happy to discuss any changes/suggestions.
Thanks
See merge request !1541
Occasionally the loading spinner would stay visible after the tab
finished loading. This change makes the toggle explicit so that it's
always shown on `beforeSend`, and always hidden on `complete`.
Plus a bonus semi-colon eradication! 💥
Fixes GDK issue where repos would not be imported properly
Seed-Fu runs this entire fixture in a transaction, so the `after_commit`
hook won't run until after the fixture is loaded. That is too late
since the Sidekiq::Testing block has already exited. Force clearing
the `after_commit` queue to ensure the job is run now.
See: gitlab-org/gitlab-development-kit#58
See merge request !1513
By using a JOIN we can remove the need for using 2 separate queries to
find a project by its namespace. Combined with an index (only needed for
PostgreSQL) this reduces the query time from ~245 ms (~520 ms for the
first call) down to roughly 10 ms (~15 ms for the first call).
Hannes Rosenögger
Robert Speicher
Dale Noe
Dmitriy Zaporozhets
Robert Speicher
Jerry LukinsandJerry Lukins
Stan Hu
Douwe Maan
Sytse Sijbrandij
Jacob Vosmaer
Han Loong Liauw
Drew Blessing
Yorick Peterse
