Commit Graph
15623 Commits
Author SHA1 Message Date
Douwe Maan dfebcb89e6 Don't save unchanged user map items to the DB. 2015-04-17 13:32:29 +02:00
Marin Jankovski 5456b00f27 Merge pull request #8212 from dmedvinsky/fix-url-field
Fix auto-selection of URL field with X11 selection
2015-04-17 10:59:20 +02:00
Marin Jankovski e988cdba47 Merge branch 'master' of github.com:gitlabhq/gitlabhq 2015-04-17 10:58:15 +02:00
Dmitry Medvinsky 92544df8da Fix auto-selection of URL field with X11 selection
We use `focusin` event instead of `click` because when using the latter,
when the selection is created it isn't put into X11 PRIMARY selection.
And as a Linux user I'm very used to such behaviour that when something
gets selected, it's ready for pasting, which is the primary purpose of
the clone URL field.

When `focusin` is used, the selection is copied to X11 buffer
automatically, so it works as expected (tested in Firefox and Chrome).
2015-04-17 10:16:18 +03:00
Dmitriy Zaporozhets f71a4b145a Merge pull request #9147 from jvanbaarsen/changelof-7-11
Added changelog for 7.11
2015-04-16 17:38:31 +03:00
Jeroen van Baarsen a4d9394b46 Added changelog for 7.11
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
2015-04-16 16:16:01 +02:00
Dmitriy Zaporozhets 36677a9b54 Merge branch 'update-changelog' into 'master'
Add 7.9.4 to CHANGELOG

See merge request !531
2015-04-16 13:51:06 +00:00
Dmitriy Zaporozhets e24ed47f8f Merge branch 'master' of github.com:gitlabhq/gitlabhq 2015-04-16 15:29:43 +03:00
Dmitriy Zaporozhets 9042d8d2b2 Merge pull request #9131 from chulkilee/ruby-2.1.6
ruby 2.1.6
2015-04-16 15:27:29 +03:00
Jeroen van Baarsen b18b9a55be Merge pull request #9094 from bbodenmiller/patch-1
update text to reference new location of setting
2015-04-16 14:23:38 +02:00
Job van der Voort a7760993c6 Merge branch 'update-install-guides-710' into 'master'
update guides for 7.10

See merge request !1779
2015-04-16 12:19:21 +00:00
Job van der Voort 42237e363b update guides for 7.10 2015-04-16 14:16:46 +02:00
Dmitriy Zaporozhets 2a0a48a402 Add 7.9.4 to CHANGELOG
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2015-04-16 15:16:04 +03:00
Marin Jankovski ed94cde2b2 Merge pull request #9089 from dsander/fix-merge-request-comments
Fix merge request comments on files with multiple commits
2015-04-15 19:34:38 +02:00
Dmitriy Zaporozhets fb7ce7bd13 Merge branch 'fix-mention-notification' into 'master'
Fix Mention notification level.

Fixes internal issue https://dev.gitlab.org/gitlab/gitlabhq/issues/2236.

See merge request !527
2015-04-15 16:31:34 +00:00
Dominik Sander d4fec49abc Fix merge request comments on files with multiple commits
Having a merge request with a comments on a line which is then changed
in a later commit prevented new comments from properly showing up in the
merge request show page.

 * `Note#set_diff` do not use stored the diff when creating a new note
   in merge requests (we can not be sure the diff did not changed since
   the last comment on that line)
 * Do not rely just on `outdated?` of the first note when displaying
   comments of a MR in the discussion tab, but partition the
   active/outdated notes and display them all
 * In the inline changes tab just select the active notes, so an
   outdated note does not prevent an active one from being rendered
 * Just show active comments in the side-by-side changes tab
2015-04-15 18:23:57 +02:00
Douwe Maan b73ffbd3cb Fix for snippets. 2015-04-15 17:57:26 +02:00
Douwe Maan efe9629346 Fix Mention notification level. 2015-04-15 17:57:26 +02:00
Marin Jankovski 5f78601c8a Merge branch 'fix-gitorious-test' into 'master'
Make sure user has access to namespace in import tests.

See merge request !529
2015-04-15 15:56:23 +00:00
Douwe Maan 80097606f5 Make sure user has access to namespace in import tests. 2015-04-15 16:58:43 +02:00
Dmitriy Zaporozhets 9193b94ece No tabs in code!
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2015-04-15 16:14:16 +03:00
Dmitriy Zaporozhets cc41381be4 Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce 2015-04-15 15:41:36 +03:00
Dmitriy Zaporozhets 345e32d332 Merge branch 'sstanovnik-openssh_fix' into 'master'
Fix generating SSH key fingerprints with OpenSSH 6.8.

Replaces https://github.com/gitlabhq/gitlabhq/pull/9008.

Fixes gitlab-org/gitlab-ce#1289.

cc @jacobvosmaer

See merge request !519
2015-04-15 12:40:30 +00:00
Dmitriy Zaporozhets 4c26bcbec8 Merge branch 'master' of github.com:gitlabhq/gitlabhq 2015-04-15 15:38:56 +03:00
Dmitriy Zaporozhets d2a895dad8 Merge branch 'emailsonpush-replyto' into 'master'
Set EmailsOnPush reply-to address to committer email when enabled.

Addresses private issue https://dev.gitlab.org/gitlab/gitlabhq/issues/2227.

See merge request !520
2015-04-15 12:37:51 +00:00
Dmitriy Zaporozhets 089f5b914e Merge branch 'emailsonpush-hellip' into 'master'
Don't use HTML ellipsis in EmailsOnPush subject truncated commit message.

Addresses private issue https://dev.gitlab.org/gitlab/gitlabhq/issues/2229.

Since the page is encoded as UTF-8, we don't need HTML entities anymore and can just use the character.

See merge request !521
2015-04-15 12:37:19 +00:00
Dmitriy Zaporozhets 4ab22a8c32 Merge branch 'ldap-block_auto_created_users' into 'master'
Add config var to block auto-created LDAP users.

Addresses private issue https://dev.gitlab.org/gitlab/gitlabhq/issues/2110.

See merge request !522
2015-04-15 12:36:43 +00:00
Dmitriy Zaporozhets 2705500546 Merge branch 'fix-repository-rescue' into 'master'
Don't crash when project repository doesn't exist.

See merge request !524
2015-04-15 12:36:12 +00:00
Dmitriy Zaporozhets fccc9454ff Merge branch 'search-information-leak' into 'master'
Don't leak existence of group or project via search.

Fixes gitlab/gitlab-ee#266.

See merge request !1762
2015-04-15 12:35:00 +00:00
Dmitriy Zaporozhets 1970dabea6 Merge pull request #9039 from gemnasium/update-gemnasium-gitlab-service-to-0-2-6
Update gemnasium-gitlab-service to 0.2.6
2015-04-15 15:33:09 +03:00
Dmitriy Zaporozhets e3d818a4e8 Merge branch 'invitation' into 'master'
Allow users to be invited.

Addresses private issue https://dev.gitlab.org/gitlab/gitlabhq/issues/2058.

The "Add members" panes for both Group Members and Project Members have gained a line of text by the People field.

![Screen_Shot_2015-04-10_at_14.14.32](https://gitlab.com/gitlab-org/gitlab-ce/uploads/fe990e65eccd9203d7324b492941362b/Screen_Shot_2015-04-10_at_14.14.32.png)

Entering an email address that is not already a member will give you the option to invite them.

![Screen_Shot_2015-04-10_at_14.14.48](https://gitlab.com/gitlab-org/gitlab-ce/uploads/d6b0d4571ea90f2a2e4af8f5b336e8e1/Screen_Shot_2015-04-10_at_14.14.48.png)

Choosing the option will add them to the People field. This works the right way (TM) in combination with adding existing users as members.

![Screen_Shot_2015-04-10_at_14.15.09](https://gitlab.com/gitlab-org/gitlab-ce/uploads/a618e5ec292d79578b16400dca6d4cfe/Screen_Shot_2015-04-10_at_14.15.09.png)

The invited member will be shown in the members list as such. The access level can be changed, and the invite can be revoked by deleting the member.

![Screen_Shot_2015-04-10_at_14.15.19](https://gitlab.com/gitlab-org/gitlab-ce/uploads/3695b9a6778d367b275115747579b46e/Screen_Shot_2015-04-10_at_14.15.19.png)

The invited user will receive an email with an "Accept invitation" link.

![Screen_Shot_2015-04-10_at_14.17.52](https://gitlab.com/gitlab-org/gitlab-ce/uploads/730121888153117d83c3cd0e4f5c90f6/Screen_Shot_2015-04-10_at_14.17.52.png)

If they're not already logged in, clicking this link will redirect them to the sign in/up page with a helpful notice.

![Screen_Shot_2015-04-10_at_14.18.12](https://gitlab.com/gitlab-org/gitlab-ce/uploads/1a26a5fa13321e7ef77ed8b538c8557d/Screen_Shot_2015-04-10_at_14.18.12.png)

Signing in or signing up will redirect them back to the invite detail page, where they can actually accept the invitation, which will update the member record in question to point to the user in question.

![Screen_Shot_2015-04-10_at_14.18.48](https://gitlab.com/gitlab-org/gitlab-ce/uploads/7ac33085463a99b8cfa6baa13bfa1235/Screen_Shot_2015-04-10_at_14.18.48.png)

Accepting the invitation will redirect them to the group (or project) with an appropriate notice.

![Screen_Shot_2015-04-10_at_14.18.58](https://gitlab.com/gitlab-org/gitlab-ce/uploads/7bf02a2e3bea589a11df401c23e68648/Screen_Shot_2015-04-10_at_14.18.58.png)

As currently, they will also receive this information by email.

![Screen_Shot_2015-04-10_at_14.24.00](https://gitlab.com/gitlab-org/gitlab-ce/uploads/b44a342068433a268c0a06ed9e791ffa/Screen_Shot_2015-04-10_at_14.24.00.png)

At the same time, the person who initially invited the email address is sent a notification as well, so they know of the new member and to tell them what name the user signed up with.

![Screen_Shot_2015-04-10_at_14.19.07](https://gitlab.com/gitlab-org/gitlab-ce/uploads/b29fea128186f938ec76bd7dec016b83/Screen_Shot_2015-04-10_at_14.19.07.png)

The member row on the Members page will now have been updated with the new user account.

![Screen_Shot_2015-04-10_at_14.19.23](https://gitlab.com/gitlab-org/gitlab-ce/uploads/cf503d3d1679614e03acec2e946a28c3/Screen_Shot_2015-04-10_at_14.19.23.png)

See merge request !500
2015-04-15 10:48:28 +00:00
Douwe Maan 3d0c0bd922 Add changelog item. 2015-04-15 12:45:29 +02:00
Dmitriy Zaporozhets b75866120b Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce 2015-04-15 12:56:25 +03:00
Douwe Maan b409c37671 Merge branch 'fix-stuck-mr' into 'master'
fix stuck mr

If `locked?` & `locked_at.nil?` is nil return that the merge has been locked long enough and those are old merges stuck in locked state.

Fixes #348. Related to 6487419364. Replaces !517.

/cc @DouweM

See merge request !526
2015-04-15 09:50:46 +00:00
Dmitriy Zaporozhets 3d9cbc5dcb Merge branch 'master' of github.com:gitlabhq/gitlabhq 2015-04-15 12:44:59 +03:00
Dmitriy Zaporozhets 4efbf9b6f5 Merge branch 'revert-help-link' into 'master'
Revert help link

Revert for https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/483

cc @douwe

See merge request !1776
2015-04-15 09:44:30 +00:00
Dmitriy Zaporozhets 5d1ab47bd2 Revert help link tests removal
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2015-04-15 12:13:49 +03:00
Dmitriy Zaporozhets 400c9c5ae2 Revert "Removed help link from sidebar"
This reverts commit 6fe26e3e46.
2015-04-15 12:12:58 +03:00
Douwe Maan 63b21945d2 Merge branch 'google-code-import' into 'master'
Import projects from Google Code.

Resolves #1257.

Issue import logic almost entirely taken from https://gitlab.com/o9000/google-code-to-gitlab ( ♥️ @o9000).

### To do

- [x] List projects from Google Takeout file
- [x] Import Git repository
- [x] Import issues
- [x] Link to correct attachment URL (https://code.google.com/p/support-tools/issues/detail?id=50)
- [x] Handle deleted attachments
- [x] Handle blockedOn attribute
- [x] Add directions on how to get data from Google Takeout

### Import instructions

![Screen_Shot_2015-04-03_at_16.02.21](https://gitlab.com/gitlab-org/gitlab-ce/uploads/4a87038035fbad9441cf613b8cdcc690/Screen_Shot_2015-04-03_at_16.02.21.png)

### Imported issue

![Screen_Shot_2015-04-03_at_16.25.49](https://gitlab.com/gitlab-org/gitlab-ce/uploads/b2c2eaf5ecfcf57b3c48511eb5d26db4/Screen_Shot_2015-04-03_at_16.25.49.png)

See merge request !471
2015-04-15 06:53:42 +00:00
Dmitriy Zaporozhets 0a0d6050fc Merge pull request #8905 from jasonblanchard/remove-truncation-milestone
Remove truncation from issue titles on milestone page
2015-04-15 09:22:46 +03:00
Ben Bodenmiller f517dd2606 fix stuck mr
fixes #348. related to 6487419364.
2015-04-14 23:11:13 -07:00
Robert Schilling 61c79418c4 Merge branch 'fix-spinach-unsubscribe-mr-test' into 'master'
Remove timing dependency on unsubscribe merge request test

This test failed for me once. I am now on a mission to remove `sleep` from the spinach tests.

See: http://www.elabs.se/blog/53-why-wait_until-was-removed-from-capybara

See merge request !523
2015-04-15 06:08:28 +00:00
Douwe Maan 36b54fc04f Don't crash when project repository doesn't exist. 2015-04-14 23:26:53 +02:00
Douwe Maan 9d00bb0896 Import Google Code issue assignee when mapped. 2015-04-14 23:22:14 +02:00
Douwe Maan 2f797a140b Skip issue comment when its content, updates and attachments are empty. 2015-04-14 23:13:48 +02:00
Douwe Maan 88c2639356 Remove superfluous info from invite accepted/declined mails. 2015-04-14 23:06:21 +02:00
Stan Hu 48efd65ff6 Remove timing dependency on test
See: http://www.elabs.se/blog/53-why-wait_until-was-removed-from-capybara
2015-04-14 10:34:48 -07:00
Douwe Maan 55d086ba08 Clarify config var and add to LDAP docs. 2015-04-14 18:17:46 +02:00
Douwe Maan c1531fe1d8 Add spinach tests around accepting and declining invitations. 2015-04-14 18:04:29 +02:00
Dmitriy Zaporozhets ac5af61499 Merge branch 'fix-ldap-migration' into 'master'
Fix ldap migration

We need different queries for MySQL and Postgres.

See merge request !1771
2015-04-14 16:01:26 +00:00