home/gitlabhq
2
0
Fork 0
mirror of https://github.com/wahyd4/gitlabhq.git synced 2026-08-15 07:36:41 +10:00
Code Issues Packages Projects Releases Wiki Activity
29,180 Commits 48 Branches 340 Tags
f1d74ccc8ca8e3fa91e87193fc886e9a00a636b3
Commit Graph
29180 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Fatih AcetandZ.J. van de Weg f1d74ccc8c Some design related tweaks. 2016-06-06 11:10:10 +02:00
Fatih AcetandZ.J. van de Weg 47fc235fe1 Be consistent on naming. 
It was named as $emojiBtn before I was using $emojiButton so updated them to be consistent.
 2016-06-06 11:07:22 +02:00
Fatih AcetandZ.J. van de Weg 59b34188fa Animate emoji when rendered. 2016-06-06 11:07:22 +02:00
Fatih AcetandZ.J. van de Weg ce5729139f Fix mutual exclusivity for emoji only comments. 2016-06-06 11:07:22 +02:00
Fatih AcetandZ.J. van de Weg 40c86c916e Refactor awardsHandler methods to work with votesBlock. 2016-06-06 11:07:22 +02:00
Fatih AcetandZ.J. van de Weg f261be0949 Award emoji implementation for notes. 2016-06-06 11:07:22 +02:00
Fatih AcetandZ.J. van de Weg eaff5afc9b Show emoji menu in notes. 2016-06-06 11:03:39 +02:00
ZJ van de Weg 2f9c2149a3 Backend awardables on comments 2016-06-06 11:03:39 +02:00
Grzegorz Bizon fc809d689a Merge branch 'fix/rubocop-offense-in-specs' into 'master' 
Fix rubocop offense in awardable specs

Fixes failing tests on master.

See merge request !4481
 2016-06-06 06:59:36 +00:00
Grzegorz Bizon b75945e9e4 Fix rubocop offense in awardable specs 2016-06-06 07:42:12 +02:00
Robert Speicher cc0ea13d21 Merge branch 'rubocop/enable-ambiguous-operator-rubocop-lint' into 'master' 
Enable Lint/AmbiguousOperator rubocop cop

Enforce using parentheses if ambiguous operators are detected, like `header *some_method` or `array.select &:even?`.

See #17478

See merge request !4454
 2016-06-05 19:08:56 +00:00
Robert Speicher 90a3c947a7 Fix CHANGELOG for 8.8.4 (unreleased) 
[ci skip]
 2016-06-05 14:50:33 -04:00
Achilleas Pipinellis 10758a48c5 Merge branch 'documentation-for-build-trace' into 'master' 
Document the API endpoint for gathering a build log

## What does this MR do?

Adds documentation for gathering a trace build log via the API. Documenting the following:
https://gitlab.com/gitlab-org/gitlab-ce/blob/de20bd5b31715f096db3fb0155c82b0eea992b6c/lib/api/builds.rb#L98-110

## Are there points in the code the reviewer needs to double check?

Please verify that a curl request using the same format as documented works

## Why was this MR needed?

No documentation currently exists

## What are the relevant issue numbers?

#18015 

## Screenshots (if relevant)

See merge request !4467
 2016-06-04 12:47:15 +00:00
Achilleas Pipinellis ef85b8c329 Merge branch 'fix-design-link-in-contributing' into 'master' 
Fix link to current design reference in the CONTRIBUTING guide

## What does this MR do?

It fixes an outdated link by replacing it with the up-to-date one.

See merge request !4439
 2016-06-04 12:32:12 +00:00
Jacob Schatz 83b8d4e636 Merge branch 'issue_13499' into 'master' 
Allow bulk-assign labels to issues

- [x] Allow bulk-assignment labels.
- [x] Show indeterminate state for labels present on selection.
- [x] Remove existing labels from selected items if label gets unmarked.
- [x] Fix conflicting tests.
- [x] Write tests.

Closes #13499 and #15489

See merge request !3917
 2016-06-04 10:55:29 +00:00
Alfredo Sumaran 94d9efaa8e Remove extra bracket 2016-06-03 17:14:23 -05:00
Alfredo Sumaran 7df4a3c53a Fix spec 2016-06-03 17:14:23 -05:00
Alfredo Sumaran 22b8b9a7f3 Address feedback 2016-06-03 17:14:23 -05:00
Alfredo Sumaran 228a684587 Update CHANGELOG 2016-06-03 17:14:23 -05:00
Sean McGivernandAlfredo Sumaran 071ad63630 Spec label add / delete in UpdateService 2016-06-03 17:14:23 -05:00
Sean McGivernandAlfredo Sumaran 165d799fb3 Allow bulk-updating to remove all labels 
Instead of passing `remove_label_ids`, just pass an empty array for
`label_ids` (and don't pass `add_label_ids` or `remove_label_ids`).
 2016-06-03 17:14:23 -05:00
Alfredo Sumaran d78fd6df0c Update CHANGELOG 2016-06-03 17:14:23 -05:00
Alfredo Sumaran 5ea0165175 Enhancements 2016-06-03 17:14:23 -05:00
Alfredo Sumaran 2ee779f17d Update CHANGELOG 2016-06-03 17:14:23 -05:00
Alfredo Sumaran 15108cbaac Fix spec 2016-06-03 17:14:23 -05:00
Alfredo Sumaran 812ae973db Respond to .json only 2016-06-03 17:14:23 -05:00
Alfredo Sumaran 73b528f9a3 Fix spec 2016-06-03 17:14:23 -05:00
Alfredo Sumaran 90bf5aa8f8 Add mising params 2016-06-03 17:14:23 -05:00
Alfredo Sumaran 830ccdfd3e Fix failing specs 2016-06-03 17:14:23 -05:00
Alfredo Sumaran d84f1180d8 Bulk assignment tests 2016-06-03 17:14:23 -05:00
Alfredo Sumaran dbf9df1dd2 Remove console.log 2016-06-03 17:14:23 -05:00
Alfredo Sumaran f1291b1b9f Bulk assignment implementation 2016-06-03 17:14:23 -05:00
Alfredo Sumaran f02ee98697 Tweaks for bulk assignment 2016-06-03 17:14:23 -05:00
Alfredo Sumaran 151158f1d7 Expose Issue ID 2016-06-03 17:14:23 -05:00
Alfredo Sumaran 7ee3fc8080 Expose label ID 2016-06-03 17:14:23 -05:00
Alfredo Sumaran 90c2ab02b5 Add show_create param to toggle label creation option 2016-06-03 17:14:23 -05:00
Alfredo Sumaran d09114e4ed Add show_footer parameter for ability to hide footer 2016-06-03 17:14:23 -05:00
Alfredo Sumaran 0be26a47f2 Do not trigger keyup event if we are persisting state 
Triggering keyup will re-render the dropdown which is not needed when option persistWhenHide is true
 2016-06-03 17:14:23 -05:00
Alfredo Sumaran 9df4da4bc0 Remove unneeded call to keyup event 
This was re-rendering the dropdown unnecessarily
 2016-06-03 17:14:23 -05:00
Alfredo Sumaran 5d7445198f Only filter asynchronously if option remote is true. 
We need to update the results right away when we do bulk assignment.
 2016-06-03 17:14:23 -05:00
Alfredo Sumaran 116f5f26ea Fix statement 2016-06-03 17:14:23 -05:00
Sean McGivernandAlfredo Sumaran 0fcf6e1094 Tidy up BulkUpdateService specs 
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
   of an array, as that's how they're passed by the front-end. (The
   deprecation warning is for passing a nested array, which is what
   happens if an actual array is passed, as:
     `[1, 2, 3].split(',') == [[1, 2, 3]]`
 2016-06-03 17:14:23 -05:00
Sean McGivernandAlfredo Sumaran ac40843c94 fixup! WIP: allow adding and removing labels in bulk 2016-06-03 17:11:41 -05:00
Sean McGivernandAlfredo Sumaran 81a21c945e WIP: allow adding and removing labels in bulk 2016-06-03 17:11:41 -05:00
Alfredo Sumaran e42f88ca37 Restore dropdown state when unchecking all issues 2016-06-03 17:11:41 -05:00
Alfredo Sumaran 5a474ff8da Ensure we are clicking a visible dropdown 2016-06-03 17:11:41 -05:00
Alfredo Sumaran 7712aaf2a7 Add space 2016-06-03 17:11:41 -05:00
Alfredo Sumaran 112f6a1e6d Add empty line to end of file 2016-06-03 17:11:41 -05:00
Alfredo Sumaran e250e8571b Bulk assignment tests 2016-06-03 17:11:41 -05:00
Alfredo Sumaran 558ef36f6c Do not remove inputs when dropdown menu hides 2016-06-03 17:11:41 -05:00