home/pinpoint
2
0
Fork 0
mirror of https://github.com/wahyd4/pinpoint.git synced 2026-08-19 01:35:58 +10:00
Code Issues Packages Projects Releases Wiki Activity

[#noissue] cleanup testcase

Browse Source 
- remove only()
This commit is contained in:
emeroad
2017-04-03 22:13:51 +09:00
committed by Woonduk Kang
parent 3d6b9490cb
commit 10ffbeb331
13 changed files with 33 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bootstrap-core/src/test/java/com/navercorp/pinpoint/bootstrap/plugin/jdbc/interceptor/DriverConnectInterceptorTest.java
+2 -2
View File
@@ -55,8 +55,8 @@ public class DriverConnectInterceptorTest {
driverConnectInterceptor.prepareAfterTrace(driver, va(invalidJdbcUrl), setAccessor, null);
driverConnectInterceptor.doInAfterTrace(spanEventRecorder, driver, va(invalidJdbcUrl), getAccessor, null);
verify(setAccessor, only())._$PINPOINT$_setDatabaseInfo(UnKnownDatabaseInfo.INSTANCE);
verify(getAccessor, only())._$PINPOINT$_getDatabaseInfo();
verify(setAccessor, times(1))._$PINPOINT$_setDatabaseInfo(UnKnownDatabaseInfo.INSTANCE);
verify(getAccessor, times(1))._$PINPOINT$_getDatabaseInfo();
}
@Test
collector/src/test/java/com/navercorp/pinpoint/collector/rpc/handler/AgentEventHandlerTest.java
+2 -2
View File
@@ -89,7 +89,7 @@ public class AgentEventHandlerTest {
ArgumentCaptor<AgentEventBo> argCaptor = ArgumentCaptor.forClass(AgentEventBo.class);
// when
this.agentEventHandler.handleEvent(this.pinpointServer, TEST_EVENT_TIMESTAMP, expectedEventType);
verify(this.agentEventDao, only()).insert(argCaptor.capture());
verify(this.agentEventDao, times(1)).insert(argCaptor.capture());
// then
AgentEventBo actualAgentEventBo = argCaptor.getValue();
assertEquals(TEST_AGENT_ID, actualAgentEventBo.getAgentId());
@@ -111,7 +111,7 @@ public class AgentEventHandlerTest {
// when
this.agentEventHandler.handleEvent(this.pinpointServer, TEST_EVENT_TIMESTAMP, expectedEventType,
expectedMessageBody);
verify(this.agentEventDao, only()).insert(argCaptor.capture());
verify(this.agentEventDao, times(1)).insert(argCaptor.capture());
// then
AgentEventBo actualAgentEventBo = argCaptor.getValue();
assertEquals(TEST_AGENT_ID, actualAgentEventBo.getAgentId());
collector/src/test/java/com/navercorp/pinpoint/collector/rpc/handler/AgentLifeCycleHandlerTest.java
+1 -1
View File
@@ -170,7 +170,7 @@ public class AgentLifeCycleHandlerTest {
// when
this.agentLifeCycleHandler.handleLifeCycleEvent(this.pinpointServer, TEST_EVENT_TIMESTAMP, expectedLifeCycleState, expectedEventCounter);
verify(this.agentLifeCycleDao, only()).insert(argCaptor.capture());
verify(this.agentLifeCycleDao, times(1)).insert(argCaptor.capture());
// then
AgentLifeCycleBo actualAgentLifeCycleBo = argCaptor.getValue();
commons/src/test/java/com/navercorp/pinpoint/common/util/DelegateEnumerationTest.java
+1 -1
View File
@@ -76,7 +76,7 @@ public class DelegateEnumerationTest {
DelegateEnumeration<String> delegateEnumeration = new DelegateEnumeration<String>(enumeration);
Assert.assertNull(delegateEnumeration.nextElement());
verify(enumeration, only()).nextElement();
verify(enumeration, times(1)).nextElement();
Assert.assertNull(delegateEnumeration.nextElement());
verify(enumeration, times(2)).nextElement();
plugins/jboss/src/test/java/com/navercorp/pinpoint/plugin/jboss/InvokeMethodInterceptorTest.java
+2 -2
View File
@@ -107,7 +107,7 @@ public class InvokeMethodInterceptorTest {
interceptor.before("target", new Object[] { request, response });
interceptor.after("target", new Object[] { request, response }, new Object(), null);
verify(traceContext, only()).newTraceObject();
verify(traceContext, times(1)).newTraceObject();
interceptor.before("target", new Object[] { request, response });
interceptor.after("target", new Object[] { request, response }, new Object(), null);
@@ -175,7 +175,7 @@ public class InvokeMethodInterceptorTest {
interceptor.before("target", new Object[] { request, response });
interceptor.after("target", new Object[] { request, response }, new Object(), null);
verify(traceContext, only()).continueTraceObject(any(TraceId.class));
verify(traceContext, times(1)).continueTraceObject(any(TraceId.class));
interceptor.before("target", new Object[] { request, response });
interceptor.after("target", new Object[] { request, response }, new Object(), null);
plugins/spring/src/test/java/com/navercorp/pinpoint/plugin/spring/beans/interceptor/BeanMethodInterceptorTest.java
+2 -2
View File
@@ -22,7 +22,7 @@ import com.navercorp.pinpoint.test.mock.MockTraceContext;
import org.junit.Test;
import org.mockito.Mockito;
import static org.mockito.Mockito.only;
import static org.mockito.Mockito.times;
/**
@@ -49,6 +49,6 @@ public class BeanMethodInterceptorTest {
final Exception throwable = new Exception();
beanMethodInterceptor.after(thisObject, 10, null, null, throwable);
Mockito.verify(recorder, only()).recordException(true, throwable);
Mockito.verify(recorder, times(1)).recordException(true, throwable);
}
}
plugins/tomcat/src/test/java/com/navercorp/pinpoint/plugin/tomcat/InvokeMethodInterceptorTest.java
+2 -2
View File
@@ -91,7 +91,7 @@ public class InvokeMethodInterceptorTest {
interceptor.before("target", new Object[]{request, response});
interceptor.after("target", new Object[]{request, response}, new Object(), null);
verify(traceContext, only()).newTraceObject();
verify(traceContext, times(1)).newTraceObject();
interceptor.before("target", new Object[]{request, response});
interceptor.after("target", new Object[]{request, response}, new Object(), null);
@@ -151,7 +151,7 @@ public class InvokeMethodInterceptorTest {
interceptor.before("target", new Object[]{request, response});
interceptor.after("target", new Object[]{request, response}, new Object(), null);
verify(traceContext, only()).continueTraceObject(any(TraceId.class));
verify(traceContext, times(1)).continueTraceObject(any(TraceId.class));
interceptor.before("target", new Object[]{request, response});
interceptor.after("target", new Object[]{request, response}, new Object(), null);
profiler/src/test/java/com/navercorp/pinpoint/profiler/context/ListenableAsyncStateTest.java
+1 -1
View File
@@ -34,7 +34,7 @@ public class ListenableAsyncStateTest {
listenableAsyncState.await();
listenableAsyncState.finish();
verify(mock, only()).finish();
verify(mock, times(1)).finish();
}
profiler/src/test/java/com/navercorp/pinpoint/profiler/context/SpanAsyncStateListenerTest.java
+9 -7
View File
@@ -20,7 +20,9 @@ import com.navercorp.pinpoint.profiler.context.id.ListenableAsyncState;
import com.navercorp.pinpoint.profiler.context.storage.Storage;
import org.junit.Test;
import static org.mockito.Mockito.*;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
/**
* @author Woonduk Kang(emeroad)
@@ -36,13 +38,13 @@ public class SpanAsyncStateListenerTest {
ListenableAsyncState.AsyncStateListener listener = new SpanAsyncStateListener(span, storage);
listener.finish();
verify(span, only()).isTimeRecording();
verify(storage, only()).store(span);
verify(span, times(1)).isTimeRecording();
verify(storage, times(1)).store(span);
//
listener.finish();
verify(span, only()).isTimeRecording();
verify(storage, only()).store(span);
verify(span, times(1)).isTimeRecording();
verify(storage, times(1)).store(span);
}
@Test
@@ -53,8 +55,8 @@ public class SpanAsyncStateListenerTest {
ListenableAsyncState.AsyncStateListener listener = new SpanAsyncStateListener(span, storage);
listener.finish();
listener.finish();
verify(span, only()).isTimeRecording();
verify(storage, only()).store(span);
verify(span, times(1)).isTimeRecording();
verify(storage, times(1)).store(span);
}
profiler/src/test/java/com/navercorp/pinpoint/profiler/instrument/BytecodeDumpServiceTest.java
+4 -4
View File
@@ -14,7 +14,7 @@ import org.mockito.runners.MockitoJUnitRunner;
import java.util.Collections;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.only;
import static org.mockito.Mockito.times;
/**
* @author Woonduk Kang(emeroad)
@@ -42,9 +42,9 @@ public class BytecodeDumpServiceTest {
bytecodeDumpService.dumpBytecode("testDump", classInternalName, classFile, classLoader);
Mockito.verify(this.disassembler, only()).dumpBytecode(classFile);
Mockito.verify(this.disassembler, only()).dumpVerify(classFile, classLoader);
Mockito.verify(this.disassembler, only()).dumpASM(classFile);
Mockito.verify(this.disassembler, times(1)).dumpBytecode(classFile);
Mockito.verify(this.disassembler, times(1)).dumpVerify(classFile, classLoader);
Mockito.verify(this.disassembler, times(1)).dumpASM(classFile);
}
profiler/src/test/java/com/navercorp/pinpoint/profiler/metadata/DefaultApiMetaDataServiceTest.java
+2 -2
View File
@@ -41,11 +41,11 @@ public class DefaultApiMetaDataServiceTest {
int first = apiMetaDataService.cacheApi(methodDescriptor);
Assert.assertNotEquals("not exist", first, 0);
verify(dataSender, only()).request(any(TBase.class));
verify(dataSender, times(1)).request(any(TBase.class));
int second = apiMetaDataService.cacheApi(methodDescriptor);
Assert.assertEquals("check cache", first, second);
verify(dataSender, only()).request(any(TBase.class));
verify(dataSender, times(1)).request(any(TBase.class));
}
}
profiler/src/test/java/com/navercorp/pinpoint/profiler/metadata/DefaultSqlMetaDataServiceTest.java
+3 -2
View File
@@ -25,6 +25,7 @@ import org.junit.Test;
import static org.mockito.Matchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.only;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
/**
@@ -43,10 +44,10 @@ public class DefaultSqlMetaDataServiceTest {
boolean newValue = sqlMetaDataService.cacheSql(parsingResult);
Assert.assertTrue(newValue);
verify(dataSender, only()).request(any(TBase.class));
verify(dataSender, times(1)).request(any(TBase.class));
boolean notNewValue = sqlMetaDataService.cacheSql(parsingResult);
Assert.assertFalse(notNewValue);
verify(dataSender, only()).request(any(TBase.class));
verify(dataSender, times(1)).request(any(TBase.class));
}
}
profiler/src/test/java/com/navercorp/pinpoint/profiler/metadata/DefaultStringMetaDataServiceTest.java
+2 -2
View File
@@ -39,11 +39,11 @@ public class DefaultStringMetaDataServiceTest {
int first = stringMetaDataService.cacheString(str);
Assert.assertNotEquals("not exist", first, 0);
verify(dataSender, only()).request(any(TBase.class));
verify(dataSender, times(1)).request(any(TBase.class));
int second = stringMetaDataService.cacheString(str);
Assert.assertEquals("check cache", first, second);
verify(dataSender, only()).request(any(TBase.class));
verify(dataSender, times(1)).request(any(TBase.class));
}
}