remove unused code and unchecked errors

This commit is contained in:
Christian Groschupp
2020-01-22 16:11:48 +01:00
parent 28eb5b10a4
commit ef97ffbeb2
3 changed files with 22 additions and 23 deletions
+10 -2
View File
@@ -60,8 +60,16 @@ func apiKeyCreate(d *schema.ResourceData, meta interface{}) error {
key, err := c.CreateAPIKey(&req)
if err == nil {
d.SetId(fmt.Sprintf("%d", key.ID))
d.Set("key", key.Key)
d.Set("secret", key.Secret)
err = d.Set("key", key.Key)
if err != nil {
return err
}
err = d.Set("secret", key.Secret)
if err != nil {
return err
}
} else {
log.Printf("[WARN] err creating: %s", err)
}
+4 -1
View File
@@ -71,7 +71,10 @@ func environmentRead(d *schema.ResourceData, meta interface{}) error {
return err
}
d.Set("name", env.Name)
err = d.Set("name", env.Name)
if err != nil {
return err
}
return nil
}
+8 -20
View File
@@ -87,7 +87,10 @@ func clusterCreate(d *schema.ResourceData, meta interface{}) error {
}
d.SetId(cluster.ID)
d.Set("bootstrap_servers", cluster.Endpoint)
err = d.Set("bootstrap_servers", cluster.Endpoint)
if err != nil {
return err
}
return nil
}
@@ -106,25 +109,10 @@ func clusterRead(d *schema.ResourceData, meta interface{}) error {
}
log.Printf("[WARN] hello %s", cluster.APIEndpoint)
d.Set("bootstrap_servers", cluster.Endpoint)
err = d.Set("bootstrap_servers", cluster.Endpoint)
if err != nil {
return err
}
return nil
}
func nameFromRD(d *schema.ResourceData) string {
return d.Get("name").(string)
}
func configFromRD(d *schema.ResourceData) map[string]string {
cfg := d.Get("config").(map[string]interface{})
scfg := d.Get("config_sensitive").(map[string]interface{})
config := make(map[string]string)
for k, v := range cfg {
config[k] = v.(string)
}
for k, v := range scfg {
config[k] = v.(string)
}
return config
}