Merge pull request #52 from Xylus/dev/translation

modified comments in English
This commit is contained in:
Hyun Jeong
2014-12-31 18:26:34 +09:00
7 changed files with 10 additions and 11 deletions
@@ -84,7 +84,7 @@ public class InterceptorRegistry {
public StaticAroundInterceptor getInterceptor0(int key) {
StaticAroundInterceptor interceptor = index[key];
if (interceptor == null) {
// 로직이 잘못되었을 경우 에러가 발생하지 않도록 더미를 리턴.
// return DUMMY upon wrong logic
return DUMMY;
}
return interceptor;
@@ -41,7 +41,7 @@ public class AgentClassLoaderTest {
AgentClassLoader agentClassLoader = new AgentClassLoader(new URL[0]);
agentClassLoader.setBootClass("com.navercorp.pinpoint.bootstrap.DummyAgent");
agentClassLoader.boot("agentPath", "test", new DummyInstrumentation(), new ProfilerConfig());
// TODO logger가져오는 기능이 달라져서 확인이 필요함.
// TODO need verification - implementation for obtaining logger changed
// PLoggerBinder loggerBinder = (PLoggerBinder) agentClassLoader.initializeLoggerBinder();
// PLogger test = loggerBinder.getLogger("test");
// test.info("slf4j logger test");
@@ -49,7 +49,7 @@ public class AgentClassLoaderTest {
}
private String getProjectLibDir() {
// 필요는 없으나 protectionDomain을 테스트하기 좋아 내비둠.
// not really necessary, but useful for testing protectionDomain
ProtectionDomain protectionDomain = AgentClassLoader.class.getProtectionDomain();
CodeSource codeSource = protectionDomain.getCodeSource();
URL location = codeSource.getLocation();
@@ -34,7 +34,7 @@ public class PinpointBootStrapTest {
Assert.assertTrue(PinpointBootStrap.getLoadState());
PinpointBootStrap.premain("test", new DummyInstrumentation());
// 중복 된경우를 체크 할수 있는 방법이 로그 확인 뿐이 없나??
// is leaving a log the only way to test for duplicate loading?
// ? check
}
}
@@ -44,9 +44,9 @@ public class PinpointURLClassLoaderTest {
// } catch (ClassNotFoundException e) {
//
// }
// 사실 위에 코드로 정상 테스트가 가능해야 겠지만 bootstrap testcase에서는 jar라서 찾을수 없음
// 아래 코드로 로드 하는 클래스인지 체크 정도만 하자.
// URL에 다가 pinpoint.jar를 걸면 되긴하겠지만. 관리가 힘들듯함.
// should be able to test using the above code, but it is not possible from bootstrap testcase.
// it could be possible by specifying the full path to the URL classloader, but it would be harder to maintain.
// for now, just test if DefaultAgent is specified to be loaded
Assert.assertTrue(cl.onLoadClass("com.navercorp.pinpoint.profiler.DefaultAgent"));
}
}
@@ -61,7 +61,7 @@ public class NetworkUtilsTest {
Assert.assertEquals("www.naver.com", hostFromURL1_1);
// TODO default port가 기본값으로 들어갔을 경우 어떤 처리가 맞는건가?
// TODO how should we resolve host when the url includes the default port?
String hostFromURL2 = NetworkUtils.getHostFromURL("http://www.naver.com:80");
Assert.assertEquals("www.naver.com:80", hostFromURL2);
@@ -59,7 +59,7 @@ public enum ServiceType {
/**
* Database
* xxx_EXECUTE_QUERY만 server map통계정보에 집계된다.
* shown only as xxx_EXECUTE_QUERY at the statistics info section in the server map
*/
// DB 2000
UNKNOWN_DB((short) 2050, "UNKNOWN_DB", TERMINAL, !RECORD_STATISTICS, INCLUDE_DESTINATION, NORMAL_SCHEMA),
@@ -72,9 +72,8 @@ public final class HBaseTables {
public static final byte[] MAP_STATISTICS_CALLER_CF_COUNTER = Bytes.toBytes("C");
public static final String MAP_STATISTICS_CALLEE = "ApplicationMapStatisticsCallee";
// 나중에 삭제할것. 관련 코드도같이 제거해도 됨.
// to be removed - use ver2 instead. remove relevant code as well.
public static final byte[] MAP_STATISTICS_CALLEE_CF_COUNTER = Bytes.toBytes("C");
// 신버전의 column Name저장용.
public static final byte[] MAP_STATISTICS_CALLEE_CF_VER2_COUNTER = Bytes.toBytes("D");
public static final String MAP_STATISTICS_SELF = "ApplicationMapStatisticsSelf";